[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 01/12] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 01/11] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -10526,14

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -9463,7 +9463,8 @@ class

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -290,6 +290,12 @@ Bug

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/erichkeane edited

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/erichkeane approved this

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: @erichkeane Thank you for the suggestions, I have removed the checking for C++20 and I also changed to the `Args.resize(std::min(...))` based on what you suggested. Is there anything else to be done? https://github.com/llvm/llvm-project/pull/83279

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc, TemplatePartialOrderingContext TPOC, unsigned NumCallArguments1, -

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 01/10] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/9] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: erichkeane wrote: Yeah, agree with @cor3ntin here. I don't think this needs the C++20

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: > I don't think checking for c++20 is useful because rewritten candidates are a > c++20- feature anyway Yes, but the resolution of the DR also talks about the reference type of the object parameter. (If I apply the patch retroactively the code will get simpler.)

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: cor3ntin wrote: > @erichkeane a question: this PR is partly a fix for a DR for c++20. Right

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: @erichkeane a question: this PR is partly a fix for a DR for c++20. Right now I only apply the fix for C++20 and newer. Is there a reason for not applying this fix for older standards? I don't see how it would break any existing code, and making the fix retroactive doesn't make

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/8] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: I have added tests for rvalref-s and `volatile`-s. https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -68,3 +68,35 @@ template struct X {}; X<1> x; #endif } +namespace dr2445 { // dr2445: 19 HoBoIs wrote: done https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/7] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: Endilll wrote: > I have added tests to other files what are relevant for the DR too. Should I > move them here? I trust your judgement

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: > DR changes looks good now, save for a nitpick. However, I'm leaving it to > other reviewers to check contents of the test. It looks like an example from > the DR, but I don't feel qualified to say whether this test has sufficient > coverage. I have added tests to other files

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll approved this pull request. DR changes looks good now, save for a nitpick. However, I'm leaving it to other

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -68,3 +68,35 @@ template struct X {}; X<1> x; #endif } +namespace dr2445 { // dr2445: 19

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/83279 ___

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20 Partial ordering with rewritten candidates -Unknown +Clang 18 HoBoIs wrote: done

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/83279 >From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate(

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20 Partial ordering with rewritten candidates -Unknown +Clang 18 HoBoIs wrote: I'm on it. While we are at here:

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -14478,7 +14478,7 @@ C++ defect report implementation status https://cplusplus.github.io/CWG/issues/2445.html;>2445 C++20

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll requested changes to this pull request. https://github.com/llvm/llvm-project/pull/83279

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/5] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc, TemplatePartialOrderingContext TPOC, unsigned NumCallArguments1, -

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc, TemplatePartialOrderingContext TPOC, unsigned NumCallArguments1, -

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/4] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc, TemplatePartialOrderingContext TPOC, unsigned NumCallArguments1, -

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

@@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc, TemplatePartialOrderingContext TPOC, unsigned NumCallArguments1, -

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath Message-ID: In-Reply-To: @@ -5548,13 +5504,100 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?Istv=C3=A1n_Horv=C3=A1th?=,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/erichkeane commented: This is close I think, just needs tests + ReleaseNotes.rst entry. https://github.com/llvm/llvm-project/pull/83279

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath Message-ID: In-Reply-To: https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/3] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: @@ -5333,11 +5333,31 @@ bool Sema::CheckIfFunctionSpecializationIsImmediate(FunctionDecl *FD, return false; } +static QualType GetImplicitObjectParameterTypeCXX20(ASTContext , erichkeane wrote: I

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: @@ -5333,11 +5333,31 @@ bool Sema::CheckIfFunctionSpecializationIsImmediate(FunctionDecl *FD, return false; } +static QualType GetImplicitObjectParameterTypeCXX20(ASTContext , +

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: @@ -5548,13 +5514,113 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: @@ -5548,13 +5514,113 @@ static bool isAtLeastAsSpecializedAs(Sema , FunctionTemplateDecl *Sema::getMoreSpecializedTemplate( FunctionTemplateDecl *FT1, FunctionTemplateDecl *FT2, SourceLocation Loc,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

Botond =?utf-8?q?István_Horváth?Message-ID: In-Reply-To: https://github.com/erichkeane commented: This needs tests plus a release note. Also, there is a lot of repeated code between the pre-c++20 and c++20 versions that will make this really hard to maintain, particularly with core issues,

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/83279 From 68200ecf3267d1b3940fa73c25c50ee706932a98 Mon Sep 17 00:00:00 2001 From: Botond Istvan Horvath Date: Wed, 28 Feb 2024 13:09:15 +0100 Subject: [PATCH 1/2] Bugfix for choosing the more specialized overload

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8e51b22ce21b01ae0be8267c5da3703ffd3b2c5b 68200ecf3267d1b3940fa73c25c50ee706932a98 --

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

HoBoIs wrote: @zygoloid @erichkeane Could you take a look? https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Botond István Horváth (HoBoIs) Changes There was a bug in clang where it couldn't choose which overload candidate is more specialized if it was comparing a member-function to a non-member function. Previously, this was detected as an

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/83279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits