Carlos =?utf-8?q?G=C3=A1lvez?=
Message-ID:
In-Reply-To:
shafik wrote:
Thank you for doing this work.
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Carlos =?utf-8?q?G=C3=A1lvez?=
Message-ID:
In-Reply-To:
smeenai wrote:
https://github.com/boostorg/mpl/issues/69 is still a problem, unfortunately.
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp closed
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp updated
https://github.com/llvm/llvm-project/pull/67528
>From 08b5c95bea5b7bfceeae6dfc4deac764faff87a6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20G=C3=A1lvez?=
Date: Wed, 27 Sep 2023 08:07:01 +
Carlos =?utf-8?q?G=C3=A1lvez?= ,
Carlos =?utf-8?q?G=C3=A1lvez?=
Message-ID:
In-Reply-To:
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
Carlos =?utf-8?q?G=C3=A1lvez?= ,
Carlos =?utf-8?q?G=C3=A1lvez?=
Message-ID:
In-Reply-To:
carlosgalvezp wrote:
Friendly ping @AaronBallman @shafik
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
dwblaikie wrote:
> It seems checks are broken on trunk, I see commits merged with failing
> pre-merge tests. They seem to be unrelated to this patch though.
>
> Is there anything else you'd like fixed before
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
carlosgalvezp wrote:
It seems checks are broken on trunk, I see commits merged with failing
pre-merge tests. They seem to be unrelated to this patch though.
Is there anything else you'd like fixed before merging?
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp updated
https://github.com/llvm/llvm-project/pull/67528
>From 7a70366e08f2c2f1181bb74f7716d8b1e3f1b62e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20G=C3=A1lvez?=
Date: Wed,
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp resolved
https://github.com/llvm/llvm-project/pull/67528
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
carlosgalvezp wrote:
I would need some help with the failing pre-merge test, I don't really
understand why that failure would be related to this patch...
https://github.com/llvm/llvm-project/pull/67528
Carlos =?utf-8?q?Gálvez?= ,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp updated
https://github.com/llvm/llvm-project/pull/67528
>From f9c4fb4e0a5a9017da6214fb0d98f45f89ee16be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20G=C3=A1lvez?=
Date: Wed,
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
@@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning<
InGroup>;
def warn_constexpr_unscoped_enum_out_of_range : Warning<
"integer value %0 is outside the valid range of values [%1, %2] for the "
-
Carlos =?utf-8?q?Gálvez?=
Message-ID:
In-Reply-To:
https://github.com/carlosgalvezp updated
https://github.com/llvm/llvm-project/pull/67528
>From f9c4fb4e0a5a9017da6214fb0d98f45f89ee16be Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Carlos=20G=C3=A1lvez?=
Date: Wed, 27 Sep 2023 08:07:01 +
@@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning<
InGroup>;
def warn_constexpr_unscoped_enum_out_of_range : Warning<
"integer value %0 is outside the valid range of values [%1, %2] for the "
- "enumeration type %3">, DefaultError,
InGroup>;
+
@@ -405,7 +405,8 @@ def warn_fixedpoint_constant_overflow : Warning<
InGroup>;
def warn_constexpr_unscoped_enum_out_of_range : Warning<
"integer value %0 is outside the valid range of values [%1, %2] for the "
- "enumeration type %3">, DefaultError,
InGroup>;
+
llvmbot wrote:
@llvm/pr-subscribers-clang
Changes
…macros
As per review comments on https://reviews.llvm.org/D150226, we should allow for
one more release before turning this warning into a hard error, by making it
visible in system headers and macros, so that people are aware of it and
https://github.com/carlosgalvezp created
https://github.com/llvm/llvm-project/pull/67528
…macros
As per review comments on https://reviews.llvm.org/D150226, we should allow for
one more release before turning this warning into a hard error, by making it
visible in system headers and macros,
18 matches
Mail list logo
