DavidSpickett wrote:
If you are doing more contributions you can get commit access by doing
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access. Though with
the switch to Github it's super easy to ask the reviewer to click the merge
button, so it's not required.
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cbalint13 wrote:
@DavidSpickett ,
> Looks good to me, thanks for working on this.
Thank you very much for the time !
> I'm not sure if you'll have permissions to click the merge button but if you
> do, go ahead.
* No, don't, I am outside contributor.
>Please remember to edit the final
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Looks good to me, thanks for working on this.
I'm not sure if you'll have permissions to click the merge button but if you
do, go ahead. Please remember to edit the final commit message to remove the
links to the output files.
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 4d7d748be3f1d7db94094c00c9ae0d07ecaf6b7e Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Thu, 21 Sep 2023 01:46:13 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 unresolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cbalint13 wrote:
@DavidSpickett ,
Addressed all requests.
* Here is the console output:
[console-output.txt.gz](https://github.com/llvm/llvm-project/files/12677908/console-output.txt.gz)
```
$ zcat ~/console-output.txt.gz | grep 'print'
$ ./bin/clang --target=arm-unknown-linux-gnu
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 707106f0a42f9682af5354aa46f28155471fd5f2 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Thu, 21 Sep 2023 00:56:09 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 3ab99383074e775da3b25a3be68780ed437e91d0 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 13:36:13 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 unresolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 deleted
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,9 +11,10 @@
//
//===--===//
-#include "llvm/TargetParser/ARMTargetParser.h"
#include "llvm/ADT/StringSwitch.h"
+#include "llvm/Support/Format.h"
#include "llvm/Support/raw_ostream.h"
+#include
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -210,24 +210,42 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
- outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) << "Version\n";
+void llvm::getAllExtensions(StringMap ) {
+ for
@@ -210,24 +210,42 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
- outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) << "Version\n";
+void llvm::getAllExtensions(StringMap ) {
+ for
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
cbalint13 wrote:
I remove it (all), and add only partial fillers.
https://github.com/llvm/llvm-project/pull/66715
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
cbalint13 wrote:
It was men't as example. Anyway, prior certain versions (in our case 18) that
accessor is still
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
DavidSpickett wrote:
An external project needing something is not a reason to add methods in tree.
It could be part of
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
DavidSpickett wrote:
Ok but I'll refer you to MaskRay's comment there:
```
We need justification to have this API,
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
cbalint13 wrote:
Regarding accesors see [these lines]
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
cbalint13 wrote:
I would leave it.
It's fine for endusers to have an API with an accessor to the *full* list of
what
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
@@ -210,24 +210,42 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
- outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) << "Version\n";
+void llvm::getAllExtensions(StringMap ) {
+ for
@@ -1012,11 +1013,18 @@ TEST(TargetParserTest, getARMCPUForArch) {
TEST(TargetParserTest, ARMPrintSupportedExtensions) {
std::string expected = "All available -march extensions for ARM\n\n"
- "\tcrc\n\tcrypto\n\tsha2";
+ "
@@ -198,13 +199,20 @@ static int PrintSupportedExtensions(std::string
TargetStr) {
std::unique_ptr TheTargetMachine(
TheTarget->createTargetMachine(TargetStr, "", "", Options,
std::nullopt));
const llvm::Triple = TheTargetMachine->getTargetTriple();
+ const
@@ -210,24 +210,42 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
- outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) << "Version\n";
+void llvm::getAllExtensions(StringMap ) {
+ for
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,7 +23,8 @@ struct RISCVExtensionInfo {
unsigned MinorVersion;
};
-void riscvExtensionsHelp();
+void getAllExtensions(StringMap );
DavidSpickett wrote:
This can go if you just set the description of only one extension in the tests.
@@ -600,11 +601,16 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
- outs() << "All available -march extensions for ARM\n\n";
+void
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
@@ -11,9 +11,10 @@
//
//===--===//
-#include "llvm/TargetParser/ARMTargetParser.h"
#include "llvm/ADT/StringSwitch.h"
+#include "llvm/Support/Format.h"
#include "llvm/Support/raw_ostream.h"
+#include
@@ -4,14 +4,17 @@
// RUN: %if aarch64-registered-target %{ %clang --target=aarch64-linux-gnu \
// RUN: --print-supported-extensions 2>&1 | FileCheck %s --check-prefix
AARCH64 %}
// AARCH64: All available -march extensions for AArch64
+// AARCH64: Name
https://github.com/DavidSpickett requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 5ee5580985ca83ef8399e1912c87b24df8b2b85e Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 10:25:33 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From ef28607fec310ca190a41bc6cba25b9ba80dd75b Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 10:23:08 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
cbalint13 wrote:
@DavidSpickett ,
The new output:
[console-output.txt.gz](https://github.com/llvm/llvm-project/files/12668489/console-output.txt.gz)
```
$ zcat console-output.txt.gz | grep 'print'
$ ./bin/clang --target=arm-unknown-linux-gnu --print-supported-extensions
$ ./bin/clang
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 resolved
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 13527e78686e18d020cefe1a88e0f9c37887b7c5 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:54:14 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From ccd3e5f62af208af38f02f76ca018724712f1d5a Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:51:33 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 468f86f2c856f163d4d1b9abdb2ef7d98934fd5f Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:39:19 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 371b465939f86990edbe16f19e7d5a4b2db09a00 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:26:11 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 2e51ca182adac1dca22d390a6494dd8b9ffba7cd Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:15:04 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 4ef7b54508b7ff3f17f29d1763b90b963a8f390e Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:12:52 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From 3e744b6e80f5074613a01d17ad9125ac79fdf83f Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 06:07:43 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
https://github.com/cbalint13 updated
https://github.com/llvm/llvm-project/pull/66715
>From d3072f481595d1840551a9f8ed322fa64d336a10 Mon Sep 17 00:00:00 2001
From: Balint Cristian
Date: Wed, 20 Sep 2023 05:59:32 +0300
Subject: [PATCH] [clang] Enable descriptions for --print-supported-extensions
@@ -210,24 +210,33 @@ static void verifyTables() {
#endif
}
-void llvm::riscvExtensionsHelp() {
+void llvm::riscvExtensionsHelp(std::map llvmDescMap) {
+
outs() << "All available -march extensions for RISC-V\n\n";
- outs() << '\t' << left_justify("Name", 20) <<
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1016,7 +1017,8 @@ TEST(TargetParserTest, ARMPrintSupportedExtensions) {
outs().flush();
testing::internal::CaptureStdout();
- ARM::PrintSupportedExtensions();
+ std::map EmptyMap;
DavidSpickett wrote:
Yeah that's fine. All it should check is that
@@ -600,11 +601,17 @@ StringRef ARM::getARMCPUForArch(const llvm::Triple
, StringRef MArch) {
llvm_unreachable("invalid arch name");
}
-void ARM::PrintSupportedExtensions() {
+void ARM::PrintSupportedExtensions(std::map llvmDescMap)
{
outs() << "All available -march
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cbalint13 edited
https://github.com/llvm/llvm-project/pull/66715
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 123 matches
Mail list logo
