john-brawn-arm wrote:
As a result of this commit clang no longer gives an error for
```
template struct X {
enum E { a };
};
template struct Y : X {
Y::E m;
};
```
where gcc (though not msvc) gives an error: https://godbolt.org/z/qGfnzhfsK
https://github.com/llvm/llvm-project/pull/73018
_
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
}
}
}
-// If typo correction failed or was not performed, fall through
-[[fallthrough]];
+Result.suppressDiagnostics();
+return nullptr;
+ cas
https://github.com/cor3ntin approved this pull request.
That looks reasonable to me modulo nit and @shafik comments.
Thanks for fixing this!
https://github.com/llvm/llvm-project/pull/73018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:/
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/73018
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
}
}
}
-// If typo correction failed or was not performed, fall through
-[[fallthrough]];
+Result.suppressDiagnostics();
+return nullptr;
+ cas
@@ -482,8 +481,23 @@ ParsedType Sema::getTypeName(const IdentifierInfo &II,
SourceLocation NameLoc,
}
}
}
-// If typo correction failed or was not performed, fall through
-[[fallthrough]];
+Result.suppressDiagnostics();
+return nullptr;
+ cas
https://github.com/erichkeane approved this pull request.
The patch makes sense to me, though my knowledge of this function is limited.
Please give @cor3ntin a chance to look at it too in case he sees something I
don't.
https://github.com/llvm/llvm-project/pull/73018
_
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Due to d0d2ee0e4bbe915d649e983c12d37bcfcf58823c clang doesn't perform qualified
name lookup into the current instantiation when it has dependent bases, because
of that `getTypeName` call always re
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/73018
Due to d0d2ee0e4bbe915d649e983c12d37bcfcf58823c clang doesn't perform qualified
name lookup into the current instantiation when it has dependent bases, because
of that `getTypeName` call always returns null fo
