[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/85259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-26 Thread Timm Baeder via cfe-commits
tbaederr wrote: Right, I was just hoping for an existing unittest for `APValue`. https://github.com/llvm/llvm-project/pull/85259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: LGTM but this should be testable because `getAsString()` uses `printPretty()`: https://github.com/llvm/llvm-project/blob/e6f63a942a45e3545332cd9a43982a69a4d5667b/clang/lib/AST/Interp/FunctionPointer.h#L53,

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-25 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/85259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-18 Thread Timm Baeder via cfe-commits
tbaederr wrote: Ping https://github.com/llvm/llvm-project/pull/85259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-14 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes When printing an `_Atomic(some struct type)`, we would later run into an assertion because we do a `Ty-castAsRecordType()`, which doesn't work with an `AtomicType`. Not sure how to best write a test for,

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-14 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/85259 When printing an `_Atomic(some struct type)`, we would later run into an assertion because we do a `Ty->castAs()`, which doesn't work with an `AtomicType`. Not sure how to best write a test for, this, but