[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman approved this pull request. LGTM! Thank you for the fix! https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 947d4b418eb5b30f76ff262b1a19150aac10b9cc Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 323e569956150d46b5299129edc2db8b39c9113b Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -192,6 +192,13 @@ class AttributeCommonInfo { bool isC23Attribute() const { return SyntaxUsed == AS_C23; } + bool isAlignas() const { +// In the current state of code, IsAlignas is only configured to return AaronBallman wrote: How about: ``` //

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -192,6 +192,13 @@ class AttributeCommonInfo { bool isC23Attribute() const { return SyntaxUsed == AS_C23; } + bool isAlignas() const { +// In the current state of code, IsAlignas is only configured to return jerinphilip wrote: This refers to the

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/erichkeane commented: The comments Aaron made should be fixed, plus 1 more from me, else LGTM. https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -192,6 +192,13 @@ class AttributeCommonInfo { bool isC23Attribute() const { return SyntaxUsed == AS_C23; } + bool isAlignas() const { +// In the current state of code, IsAlignas is only configured to return erichkeane wrote: This comment is

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/erichkeane edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -451,3 +451,5 @@ namespace P2361 { // expected-warning {{use of the 'deprecated' attribute is a C++14 extension}} [[nodiscard("\123")]] int b(); // expected-error{{invalid escape sequence '\123' in an unevaluated string literal}} } +

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -264,6 +264,11 @@ Attribute Changes in Clang supports but that are never the result of default argument promotion, such as ``float``. (`#59824: `_) +- Clang now warns you that the ``_Alignas`` attribute on declaration

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman commented: Aside from some nits, I think this looks reasonable to me. I'll leave the final sign-off to @erichkeane but if he doesn't approve in the next few days (WG21 meetings are upcoming so he may be busy), I'll come back to approve. Thank you for all the

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -5339,16 +5339,22 @@ Decl *Sema::ParsedFreeStandingDeclSpec(Scope *S, AccessSpecifier AS, TypeSpecType == DeclSpec::TST_interface || TypeSpecType == DeclSpec::TST_union || TypeSpecType == DeclSpec::TST_enum) { - for (const ParsedAttr :

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

jerinphilip wrote: I have rebased the PR with main (which appears to fix the formatting workflow). For the time being, I have left the C23 test using `alignas` in with the active error message and a `FIXME`. I've altered the state of this PR to be close to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 919be6b69cf12e5d9dd9f74a4570ea0a87c9a265 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 74b62efe15496e0024271fe93418f0963c8aedd0 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From cce937359c918246cdf515045808e8868b1944d4 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH] [clang] Improve _Alignas on declaration diagnostic Adds

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/18] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/14] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -94,7 +94,7 @@ class AttributeCommonInfo { IsRegularKeywordAttribute(IsRegularKeywordAttribute) {} constexpr Form(tok::TokenKind Tok) : SyntaxUsed(AS_Keyword), SpellingIndex(SpellingNotCalculated), - IsAlignas(Tok == tok::kw_alignas), +

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -std=c23 -fsyntax-only -verify %s +// RUN: not %clang_cc1 -std=c99 -pedantic -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-EXT %s + +_Alignas(int) struct c1; // expected-warning {{attribute '_Alignas' before "struct" is ignored}}

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -std=c23 -fsyntax-only -verify %s +// RUN: not %clang_cc1 -std=c99 -pedantic -fsyntax-only %s 2>&1 | FileCheck -check-prefix=CHECK-EXT %s + +_Alignas(int) struct c1; // expected-warning {{attribute '_Alignas' before "struct" is ignored}}

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/11] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 01/10] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip updated https://github.com/llvm/llvm-project/pull/65638 >From 941af68ab8dad68ed8df65f6e0559476f137bfe2 Mon Sep 17 00:00:00 2001 From: Jerin Philip Date: Sat, 19 Aug 2023 16:43:53 +0530 Subject: [PATCH 1/7] Fix `Form` to recognize `_Alignas` in addition to

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman commented: Thank you for working on this! I think the changes should come with a release note so users know about the fix. I did have a question on the design, but overall the direction seems sensible to me. https://github.com/llvm/llvm-project/pull/65638

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -186,14 +186,14 @@ class AttributeCommonInfo { bool isGNUScope() const; bool isClangScope() const; - bool isCXX11Attribute() const { return SyntaxUsed == AS_CXX11 || IsAlignas; } - + bool isAlignas() const { return IsAlignas; } + bool isCXX11Attribute() const {

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

@@ -27,6 +27,7 @@ #include "clang/AST/Randstruct.h" #include "clang/AST/StmtCXX.h" #include "clang/Basic/Builtins.h" +#include "clang/Basic/DiagnosticSema.h" cor3ntin wrote: I don't think adding this header is necessary

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/cor3ntin commented: LGTM modulo nitpick. Maybe @AaronBallman will want to look at it too. Do we want a release notes for this? https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

AaronBallman wrote: > @AaronBallman you have a preference as to which PR we pursue? No strong preference, but the author of D141177 seems to have gone silent again so if @jerinphilip is actively working on this patch, I'd say let's go with this one.

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: @AaronBallman you have a preference as to which PR we pursue? https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: There is similar effort on Phab, we should pick one of them https://reviews.llvm.org/D141177 https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

cor3ntin wrote: Generally looks good, thanks for working on this I'd like to see more tests in `clang/test/Sema/alignas.c` - we don't have a test for `struct _Alignas(int) T` either apparently. Given this fixes a bug, it could benefit from a release note in `clang/docs/ReleaseNotes.rst`

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/github-actions[bot] labeled https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip review_requested https://github.com/llvm/llvm-project/pull/65638 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve `_Alignas` on a `struct` declaration diagnostic (PR #65638)

https://github.com/jerinphilip created https://github.com/llvm/llvm-project/pull/65638: Fixes https://github.com/llvm/llvm-project/issues/58637. Additionally accounts for `_AlignAs` when constructing Attribute Form. This breaks a few tests because `IsAlignAs` is coupled with `CXX11Attribute`.