[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/88097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

Endilll wrote: > Do we now have enough information to pass a source range as well? Yes, `TypeLoc` inside `TypeSourceInfo` has two `SourceLocation` object that represent the range. In order to limit the scope of the PR, I'm not refactoring `RequireCompleteType` and friends to accept

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

tbaederr wrote: Do we now have enough information to pass a source range as well? https://github.com/llvm/llvm-project/pull/88097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/88097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/88097 >From 3bc2d71cbe5e5613b430968fe84023a736072e54 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 9 Apr 2024 10:20:10 +0300 Subject: [PATCH 1/2] [clang] Improve source location in binary type traits

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff c7db450e5c1a83ea768765dcdedfd50f3358d418 3bc2d71cbe5e5613b430968fe84023a736072e54 --

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch takes advantage of a recent NFC change that refactored `EvaluateBinaryTypeTrait()` to accept `TypeSourceInfo` instead of `QualType` c7db450e5c1a83ea768765dcdedfd50f3358d418. Before: ```

[clang] [clang] Improve source location in binary type traits diagnostics (PR #88097)

https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/88097 This patch takes advantage of a recent NFC change that refactored `EvaluateBinaryTypeTrait()` to accept `TypeSourceInfo` instead of `QualType` c7db450e5c1a83ea768765dcdedfd50f3358d418. Before: ```