Endilll wrote:
I think I exposed a name conflict with a system header on AIX by including
`Cuda.h` in `Sema.h`. Given that this name conflict potentially affects both
enum definition and its usage, how should we resolve this?
https://github.com/llvm/llvm-project/pull/88559
Endilll wrote:
@fhahn Yeah, that's theoretically possible. I'll look into it today.
https://github.com/llvm/llvm-project/pull/88559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fhahn wrote:
Is it possible that this broke this bot failing with the error below?
```
usr/local/clang-17.0.2/bin/clang++ -DGTEST_HAS_RTTI=0 -D_CINDEX_LIB_ -D_DEBUG
-D_GLIBCXX_ASSERTIONS -D_LARGE_FILE_API -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/88559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B approved this pull request.
LGTM. The changes appear to be mechanical in nature, so `check clang` tests
should be sufficient to verify we've re-connected things correctly.
https://github.com/llvm/llvm-project/pull/88559
___
jhuber6 wrote:
Went ahead and applied this locally. Runs some trivial CUDA / HIP programs so
I'd say it's fine. I'll wait until @Artem-B or @yxsamliu chime in however as
they're the main contributors to this part.
https://github.com/llvm/llvm-project/pull/88559
jhuber6 wrote:
> > Have you run the CUDA / HIP tests in the external test suite or anything?
>
> No, just `check-clang` target. You think it's necessary to run something else
> before merging? If so, you should point me out to what to run, and preferably
> give some instructions, as CUDA
Endilll wrote:
> Have you run the CUDA / HIP tests in the external test suite or anything?
No, just `check-clang` target. You think it's necessary to run something else
before merging? If so, you should point me out to what to run, and preferably
give some instructions, as CUDA development is
@@ -0,0 +1,304 @@
+//===- SemaCUDA.h - Semantic Analysis for CUDA constructs
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
jhuber6 wrote:
I definitely like moving things out of Sema, since it's so big it always brings
my LSP to its knees. Have you run the CUDA / HIP tests in the external test
suite or anything?
https://github.com/llvm/llvm-project/pull/88559
___
@@ -0,0 +1,304 @@
+//===- SemaCUDA.h - Semantic Analysis for CUDA constructs
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/AaronBallman edited
https://github.com/llvm/llvm-project/pull/88559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Generally LGTM, though I'd like someone more familiar with CUDA to sign off as
well.
https://github.com/llvm/llvm-project/pull/88559
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch moves CUDA-related `Sema` function into new `SemaCUDA` class,
following the recent example of SYCL, OpenACC, and HLSL. This is a part of the
effort to split Sema. Additional context can be
14 matches
Mail list logo
