https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/70632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
Because we're on the fence about whether this has value and we're getting early
feedback about diagnostic chattiness and we lack adequate test coverage for the
changes, I think it's reasonable to back this out for now.
It might make
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema , Decl *D,
const ParsedAttr ) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingType =
erichkeane wrote:
> > Why doesn't this result in any changes to tests? I would expect having to
> > remove them, right?
>
> There was a single test that was relying on sign mismatch, and then during
> code review we made the diagnostic to ignore signness. So it ended up merged
> without test
Endilll wrote:
> Why doesn't this result in any changes to tests? I would expect having to
> remove them, right?
There was a single test that was relying on sign mismatch, and then during code
review we made the diagnostic to ignore signness. So it ended up merged without
test case where
https://github.com/erichkeane commented:
Why doesn't this result in any changes to tests? I would expect having to
remove them, right?
https://github.com/llvm/llvm-project/pull/70632
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema , Decl *D,
const ParsedAttr ) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingType =
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema , Decl *D,
const ParsedAttr ) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingType =
@@ -5928,28 +5928,6 @@ static void handlePreferredTypeAttr(Sema , Decl *D,
const ParsedAttr ) {
S.RequireCompleteType(ParmTSI->getTypeLoc().getBeginLoc(), QT,
diag::err_incomplete_type);
- if (QT->isEnumeralType()) {
-auto IsCorrespondingType =
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
https://github.com/llvm/llvm-project/pull/69104 introduce a diagnostic that
checked underlying type of an enum against type of bit-field that is annotated
with `[[clang::preferred_type]]`. When I
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/70632
https://github.com/llvm/llvm-project/pull/69104 introduce a diagnostic that
checked underlying type of an enum against type of bit-field that is annotated
with `[[clang::preferred_type]]`. When I tried to
11 matches
Mail list logo
