rjmccall wrote:
I definitely don't think we should be handling this in the lexer by trying to
retroactively make this a keyword. I was just thinking that we might have some
sort of parser-level recovery for e.g. `unrecognized_identifier_t x = 5;` that
might guess that
PiJoules wrote:
> I'm happy with the basic idea here of making fixed-point an opt-in feature.
> It'd be nice to preserve the special diagnostic that tells the user that they
> need to use `-ffixed-point`, though. Do we have any existing parsing paths
> that recognize unrecognized identifiers
rjmccall wrote:
I'm happy with the basic idea here of making fixed-point an opt-in feature.
It'd be nice to preserve the special diagnostic that tells the user that they
need to use `-ffixed-point`, though. Do we have any existing parsing paths
that recognize unrecognized identifiers that
https://github.com/PiJoules closed
https://github.com/llvm/llvm-project/pull/71884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/71884
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ea89965b3cfcb00a08941780da45c663cb4a6cab
b1263d73347612acd2109a88c1188054e29e0082 --
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (PiJoules)
Changes
Prior to this, clang would always report
```
compile with '-ffixed-point' to enable fixed point types
```
whenever it sees `_Accum`, `_Fract`, or `_Sat` when fixed point arithmetic is
not enabled. This can break
https://github.com/PiJoules created
https://github.com/llvm/llvm-project/pull/71884
Prior to this, clang would always report
```
compile with '-ffixed-point' to enable fixed point types
```
whenever it sees `_Accum`, `_Fract`, or `_Sat` when fixed point arithmetic is
not enabled. This can
