github-actions[bot] wrote:
@vapdrs Congratulations on having your first Pull Request (PR) merged into the
LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a build,
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vapdrs wrote:
> @vapdrs Do you need us to merge that for you? Thanks
Yes, I do not have write access to the repository. Thank you!
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cor3ntin wrote:
@vapdrs Do you need us to merge that for you? Thanks
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vapdrs updated
https://github.com/llvm/llvm-project/pull/83476
>From f66254c6be64a7270ce2df8556c540344ade0619 Mon Sep 17 00:00:00 2001
From: Douglas Deslauriers
Date: Thu, 29 Feb 2024 20:18:34 +
Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init
https://github.com/vapdrs edited https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17615,31 +17615,28 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
return VisitExpr(CCE);
// In C++11, list initializations are sequenced.
-SmallVector Elts;
-SequenceTree::Seq Parent = Region;
-for
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
LGTM after addressing comment.
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vapdrs updated
https://github.com/llvm/llvm-project/pull/83476
>From cc14e7a3320c36295514b75108e4da481d2f6b99 Mon Sep 17 00:00:00 2001
From: Douglas Deslauriers
Date: Thu, 29 Feb 2024 20:18:34 +
Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init
@@ -17626,6 +17626,25 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
for (unsigned I = 0; I < Elts.size(); ++I)
Tree.merge(Elts[I]);
}
+
+ void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) {
+// C++20 parenthesized list
@@ -17626,6 +17626,25 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
for (unsigned I = 0; I < Elts.size(); ++I)
Tree.merge(Elts[I]);
}
+
+ void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) {
+// C++20 parenthesized list
https://github.com/vapdrs updated
https://github.com/llvm/llvm-project/pull/83476
>From 85958bdf181b0cb79716a35bc4f3248e8f31c527 Mon Sep 17 00:00:00 2001
From: Douglas Deslauriers
Date: Thu, 29 Feb 2024 20:18:34 +
Subject: [PATCH] [clang] Sequence C++20 Parenthesized List Init
https://github.com/vapdrs edited https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zygoloid commented:
Thanks!
[I'm not sure when I'll have time to circle back to this, so I'd be happy for
someone else to finish the review and approve.]
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
https://github.com/zygoloid edited
https://github.com/llvm/llvm-project/pull/83476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17626,6 +17626,25 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
for (unsigned I = 0; I < Elts.size(); ++I)
Tree.merge(Elts[I]);
}
+
+ void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) {
+// C++20 parenthesized list
@@ -17626,6 +17626,25 @@ class SequenceChecker : public
ConstEvaluatedExprVisitor {
for (unsigned I = 0; I < Elts.size(); ++I)
Tree.merge(Elts[I]);
}
+
+ void VisitCXXParenListInitExpr(const CXXParenListInitExpr *PLIE) {
+// C++20 parenthesized list
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Douglas Deslauriers (vapdrs)
Changes
Parenthesized list intializers are sequenced operations, see C++20
[decl.init]p17.5 and [decl.init]p17.6.2.2 for more details.
Fixes #83474
---
Full diff:
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/vapdrs created
https://github.com/llvm/llvm-project/pull/83476
Parenthesized list intializers are sequenced operations, see C++20
[decl.init]p17.5 and [decl.init]p17.6.2.2 for more details.
Fixes #83474
>From 82e371bdcde2da8336b8679fff941f8b0a0394ae Mon Sep 17 00:00:00
23 matches
Mail list logo
