https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AMP999 wrote:
@cor3ntin Thank you! I don't have the permission to merge. Could you merge it
for me?
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
cor3ntin wrote:
@AMP999 Feel free to merge!
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AMP999 wrote:
@shafik, gentle ping!
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/fahadnayyar approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AMP999 wrote:
@fahadnayyar, does this PR address llvm#86997?
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM, thank you! No need for a release note because the changes are correcting
an issue introduced in 19.x.
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
https://github.com/shafik commented:
LGTM but I want @fahadnayyar to verify this addresses his concerns.
https://github.com/llvm/llvm-project/pull/87132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Amirreza Ashouri (AMP999)
Changes
This change improves error messages for builtins in case of empty parentheses.
Fixes llvm#86997
---
Full diff: https://github.com/llvm/llvm-project/pull/87132.diff
4 Files Affected:
- (modified)
https://github.com/AMP999 created
https://github.com/llvm/llvm-project/pull/87132
This change improves error messages for builtins in case of empty parentheses.
Fixes llvm#86997
>From f8cc36bd3706cc5744eb3223b0c32df2f6f871f9 Mon Sep 17 00:00:00 2001
From: Amirreza Ashouri
Date: Fri, 29 Mar
10 matches
Mail list logo