[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 01/10] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/6] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 75efddba0f507282df479a6e296d67fd88aed489 79b4c34eba3a96d869cf4bfc0f0d2ff358bf1b42 --

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

gedare wrote: I'm still making changes on this. Not sure how to mark that in GH. Need to add test cases for double parens, and get it working for the newly added suboptions. https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 5e5bec9fba56f34c7dd28ca866eef145035a Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/5] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

gedare wrote: > > The __attribute((specifier-list)) currently is formatted based on the > > SpacesInParensOptions.Other (previously, SpacesInParentheses). This change > > allows finer control over addition of spaces between the consecutive > > parens, and between the inner parens and the list

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/HazardyKnusperkeks approved this pull request. But Owen's proposal isn't bad either. https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/mydeveloperday approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

owenca wrote: > The __attribute((specifier-list)) currently is formatted based on the > SpacesInParensOptions.Other (previously, SpacesInParentheses). This change > allows finer control over addition of spaces between the consecutive parens, > and between the inner parens and the list of

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/5] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

@@ -16815,6 +16817,18 @@ TEST_F(FormatTest, ConfigurableSpacesInParens) { verifyFormat("void __attribute__((naked)) foo(int bar)", Spaces); verifyFormat("void f( ) __attribute__((asdf));", Spaces); + Spaces.SpacesInParensOptions.InAttributeSpecifiers = +

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/4] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare edited https://github.com/llvm/llvm-project/pull/77522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare updated https://github.com/llvm/llvm-project/pull/77522 >From 80d04b253933496d6e6c016f09f0bb987f29b2d4 Mon Sep 17 00:00:00 2001 From: Gedare Bloom Date: Mon, 17 Jul 2023 18:24:30 -0600 Subject: [PATCH 1/2] Add SpaceInParensOption for __attribute__ keyword The

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

gedare wrote: > This is migrated from Phabricator, see more discussion there. I will next > provide an option for SpacesInParensOptions.Doubled to control (and override) > injection of spaces within doubled parens `(( ))`. Actually, spaces in double parens might not work out well. It will not

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Gedare Bloom (gedare) Changes The __attribute((specifier-list)) currently is formatted based on the SpacesInParensOptions.Other (previously, SpacesInParentheses). This change allows finer control over addition of spaces between the

[clang] [clang-format] Add SpaceInParensOption for __attribute__ keyword (PR #77522)

https://github.com/gedare created https://github.com/llvm/llvm-project/pull/77522 The __attribute((specifier-list)) currently is formatted based on the SpacesInParensOptions.Other (previously, SpacesInParentheses). This change allows finer control over addition of spaces between the