https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/81958
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> LGTM, as long as someone doesn't say it should be
>
> ```c++
> #if FOO
>constexpr
> #endif
>inline
>int i = 0;
> ```
>
> but I think this change is fine..I would rather we didn't try and support
> that.. thank you.
Yep! Otherwise, you would have to handle the follo
https://github.com/mydeveloperday approved this pull request.
LGTM, as long as someone doesn't say it should be
```c++
#if FOO
constexpr
#endif
inline
int i = 0;
```
but I think this change is fine..I would rather we didn't try and support
that.. thank you.
https://github.com/llvm/ll
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #80579.
---
Full diff: https://github.com/llvm/llvm-project/pull/81958.diff
2 Files Affected:
- (modified) clang/lib/Format/QualifierAlignmentFixer.cpp (+2)
- (modified) clang/unittests/Format/Qua
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/81958
Fixes #80579.
>From 13614f5760a26ba6134abdd555176a1aa2ed3974 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 15 Feb 2024 17:37:44 -0800
Subject: [PATCH] [clang-format] Don't sort qualifiers across preprocessor
