[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

tstellar wrote: Tracking the backport request here: #81096 https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

llvmbot wrote: /pull-request llvm/llvm-project#81096 https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

owenca wrote: /cherry-pick 8f6e13e6da84 https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

@@ -1,5 +1,8 @@ +// RUN: clang-format -assume-filename=foo.m -dump-config | FileCheck %s owenca wrote: Yes, because it wouldn't make a difference before and after the patch. I don't think we can use lit to test that behavior (i.e., not waiting for an EOF) of

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

@@ -1,5 +1,8 @@ +// RUN: clang-format -assume-filename=foo.m -dump-config | FileCheck %s bhamiltoncx wrote: It looks like you reverted the lit test which just runs `clang-format -dump-config` without any other arguments. Is that what you wanted to do?

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/bhamiltoncx edited https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

@@ -0,0 +1,3 @@ +// RUN: clang-format -dump-config 2>&1 | FileCheck %s bhamiltoncx wrote: Can you also add a test with `clang-format --assume-filename=foo.m -dump-config 2>&1 | FileCheck %s`? It should result in `Language: ObjC`.

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/bhamiltoncx approved this pull request. Looks good. Can you add one more test, please? https://github.com/llvm/llvm-project/pull/80628 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/owenca updated https://github.com/llvm/llvm-project/pull/80628 >From d49f94ca7de184fb7859a2d6d3f85e9b9adcc041 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sun, 4 Feb 2024 18:29:42 -0800 Subject: [PATCH 1/2] [clang-format] Fix a regression in dumping the config Commit

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Commit d813af73f70f addressed a regression introduced by commit 3791b3fca6ea but caused `clang-format -dump-config` to "hang". This patch reverts changes to ClangFormat.cpp by both 3791b3fca6ea and

[clang] [clang-format] Fix a regression in dumping the config (PR #80628)

https://github.com/owenca created https://github.com/llvm/llvm-project/pull/80628 Commit d813af73f70f addressed a regression introduced by commit 3791b3fca6ea but caused `clang-format -dump-config` to "hang". This patch reverts changes to ClangFormat.cpp by both 3791b3fca6ea and d813af73f70f