https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
owenca wrote:
> > Thanks for trying it on 17.x. We can't backport it then.
>
> Any idea if there is another workaround or fix that we could do to target
> 17.x? 18 is still pretty far off and clang-format for 17 will soon be
> included in a lot of downstream tools. Happy to help out fixing it
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/72520
>From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 16 Nov 2023 06:36:41 -0800
Subject: [PATCH 1/4] [clang-format] Fix crashes in AlignArrayOfStructures
Fixed
@@ -20709,6 +20709,18 @@ TEST_F(FormatTest, CatchExceptionReferenceBinding) {
TEST_F(FormatTest, CatchAlignArrayOfStructuresRightAlignment) {
auto Style = getLLVMStyle();
Style.AlignArrayOfStructures = FormatStyle::AIAS_Right;
+
+ verifyNoCrash("f({\n"
+
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rymiel approved this pull request.
Thanks for doing this! There were probably dozens of duplicates of this same
crash across multiple years, so this is great
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing
tru wrote:
> Thanks for trying it on 17.x. We can't backport it then.
Any idea if there is another workaround or fix that we could do to target 17.x?
18 is still pretty far off and clang-format for 17 will soon be included in a
lot of downstream tools. Happy to help out fixing it if you have
owenca wrote:
> @owenca I picked da1b1fba5cfd41521a840202d8cf4c3796c5e10b on top of the 17.x
> branch and my test case was not fixed, it still crashes in the same way as
> described in #72628
Thanks for trying it on 17.x. We can't backport it then.
tru wrote:
@owenca I picked da1b1fba5cfd41521a840202d8cf4c3796c5e10b on top of the 17.x
branch and my test case was not fixed, it still crashes in the same way as
described in #72628
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits
tru wrote:
> We probably should backport it to 17.0.6. What do you all think? @tru
Yep - seems like a good and small fix to have in 17.x
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
owenca wrote:
We probably should backport it to 17.0.6. What do you all think? @tru
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/72520
>From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 16 Nov 2023 06:36:41 -0800
Subject: [PATCH 1/3] [clang-format] Fix crashes in AlignArrayOfStructures
Fixed
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1316,6 +1316,8 @@ void
WhitespaceManager::alignArrayInitializersRightJustified(
auto Offset = std::distance(Cells.begin(), CellIter);
for (const auto *Next = CellIter->NextColumnElement; Next;
Next = Next->NextColumnElement) {
+ if
@@ -1316,6 +1316,8 @@ void
WhitespaceManager::alignArrayInitializersRightJustified(
auto Offset = std::distance(Cells.begin(), CellIter);
for (const auto *Next = CellIter->NextColumnElement; Next;
Next = Next->NextColumnElement) {
+ if
https://github.com/owenca updated
https://github.com/llvm/llvm-project/pull/72520
>From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 16 Nov 2023 06:36:41 -0800
Subject: [PATCH 1/2] [clang-format] Fix crashes in AlignArrayOfStructures
Fixed
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1316,6 +1316,8 @@ void
WhitespaceManager::alignArrayInitializersRightJustified(
auto Offset = std::distance(Cells.begin(), CellIter);
for (const auto *Next = CellIter->NextColumnElement; Next;
Next = Next->NextColumnElement) {
+ if
@@ -1316,6 +1316,8 @@ void
WhitespaceManager::alignArrayInitializersRightJustified(
auto Offset = std::distance(Cells.begin(), CellIter);
for (const auto *Next = CellIter->NextColumnElement; Next;
Next = Next->NextColumnElement) {
+ if
https://github.com/HazardyKnusperkeks edited
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request.
https://github.com/llvm/llvm-project/pull/72520
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixed #55493.
Fixed #68431.
---
Full diff: https://github.com/llvm/llvm-project/pull/72520.diff
3 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager.cpp (+3-1)
- (modified)
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/72520
Fixed #55493.
Fixed #68431.
>From efdf321e9447e8b3f1c27ccdf6da842107deb6dd Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Thu, 16 Nov 2023 06:36:41 -0800
Subject: [PATCH] [clang-format] Fix crashes in
23 matches
Mail list logo
