s1Sharp wrote:
> @s1Sharp are there any conclusions here? our code also incidentally relied on
> having new lines between string literals, mostly for the sake of having a
> line break after string literals that end with `\n`.
>
> what do people think about restoring the functionality to break
kadircet wrote:
sent out https://github.com/llvm/llvm-project/pull/76795 for implementation
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
kadircet wrote:
@s1Sharp are there any conclusions here? our code also incidentally relied on
having new lines between string literals, mostly for the sake of having a line
break after string literals that end with `\n`.
what do people think about restoring the functionality to break after
HazardyKnusperkeks wrote:
> yes, issue with breaking after << is gone. I want to get your point about
> functionality clang-format and implementing new option such as
> "BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with
> "owenca" point?
>
> May be i can do
s1Sharp wrote:
yes, issue with breaking after << is gone. I want to get your point about
functionality clang-format and implementing new option such as
"BreakAfterStreamOperator". As i can see, @HazardyKnusperkeks you agree with
"owenca" point?
May be i can do something with this feature
HazardyKnusperkeks wrote:
What Owen says. And given that the modified lines were removed, maybe the
issue(s) are also gone?
To the review unrelated, why didn't it get the
@llvm/pr-subscribers-clang-format thing?
https://github.com/llvm/llvm-project/pull/69859
owenca wrote:
> 2th solution is: Add new option that allowing specific behaviour, such as
> "BreakAfterStreamOperator" or "BreakAfterLessLessOperator" with options [
> Leave | NoFitLine | All ].
We need a comprehensive solution to cover the following:
- when to break
- before or after the
owenca wrote:
Please add unit tests in `clang/unittests/Format/`.
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s1Sharp edited
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/s1Sharp updated
https://github.com/llvm/llvm-project/pull/69859
>From 5bbff07c636c2fc8b0432e5ca615d4cd7fd0c2b1 Mon Sep 17 00:00:00 2001
From: Tsarkov Maksim
Date: Sun, 22 Oct 2023 02:09:21 +0300
Subject: [PATCH] [clang-format] unexpected break after binOp '<<'
the problem
https://github.com/s1Sharp updated
https://github.com/llvm/llvm-project/pull/69859
>From a5c62614113b4c42e9051905bb6165331192ded0 Mon Sep 17 00:00:00 2001
From: Tsarkov Maksim
Date: Sun, 22 Oct 2023 02:09:21 +0300
Subject: [PATCH] [clang-format] unexpected break after binOp '<<'
the problem
https://github.com/s1Sharp reopened
https://github.com/llvm/llvm-project/pull/69859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
s1Sharp wrote:
I have no way to link the issues related to the PR issue. I don't know why, but
add a link to issue to this comment
https://github.com/llvm/llvm-project/issues/44363 .
So, I want to start a little discussion about the solution.
I'll start with the problem - when using the
https://github.com/s1Sharp created
https://github.com/llvm/llvm-project/pull/69859
the problem occurred while checking for the correctness of the break after
binary operators. The output statement 'tok::lessless' is then break line every
possible time, which is not expected with the
14 matches
Mail list logo
