klensy wrote:
> Ok, running https://gist.github.com/klensy/2a6cf62f228b676b73cb5b16a599b93b
> over current PR will give more hits, but with few FP, so be aware.
Funny, there already exist linter
klensy wrote:
@daniel-grumberg Moved ExtractAPI changes to
https://github.com/llvm/llvm-project/pull/92231
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klensy wrote:
Ok, running https://gist.github.com/klensy/2a6cf62f228b676b73cb5b16a599b93b
over current PR will give more hits, but with few FP, so be aware.
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
MaskRay wrote:
> Ideally FileCheck should prefix commands with some tag to distinguish
> comments from filecheck annotations, like
> `--command-tag=@` and use as `@CHECK: xxx`, `@MYCHECK-NEXT: yyy`, etc. Making
> typo\error in both prefix and command tag will be harder, i guess. That way
>
https://github.com/MaskRay approved this pull request.
Some CHECK prefixes are auto-generated by llvm/utils/update_*_test_checks.py.
Let's say my build directory is `/tmp/Rel` while my source is at `~/llvm`, use
```
PATH=/tmp/Rel/bin:$PATH ~/llvm/llvm/utils/update_any_test_checks.py path/to/test
klensy wrote:
> Were these found manually or using some automated tooling? Based on the Rust
> PR, it seems like these were found by just manually going through the results
> from a regex?
At first - yes, but later i noticed other error patterns and tried them
iteratively; maybe some edit
klensy wrote:
> When doing large scale cleanups, it might make sense to partition them, e.g.
> llvm/ (clang/ & clang-tools-extra/) mlir/ in different PRs. The number of
> files will be smaller and github web UI will not make the page too slow to
> load. The active contributors in these
boomanaiden154 wrote:
Were these found manually or using some automated tooling? Based on the Rust
PR, it seems like these were found by just manually going through the results
from a regex?
https://github.com/llvm/llvm-project/pull/91854
___
MaskRay wrote:
The previous failures reported by `buildkite/github-pull-requests Pending` were
genuine. I have fixed them separately.
When doing large scale cleanups, it might make sense to partition them, e.g.
llvm/ (clang/ & clang-tools-extra/) mlir/ in different PRs. The number of files
https://github.com/klensy edited https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -335,7 +335,7 @@ define void @cannot_sink_reduction(i32 %x, ptr %ptr, i64
%tc) {
-; CHECK-NET: ret void
+; CHECK-NEXT:ret void
mshockwave wrote:
please remove this line as it has been covered by line 333 (which was probably
generated by UTC).
@@ -96,7 +96,7 @@ for.end: ; preds =
%for.end.loopexit, %
; Specify a smaller minimum VF (via `-epilogue-vectorization-minimum-VF=4`) and
; make sure the epilogue gets vectorized in that case.
-; CHECK-MIN-D-LABLE: @f3
+;
dwblaikie wrote:
@pogo59 - you might find this interesting in terms of bitrotten tests, etc.
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/tblah commented:
Thank you for the cleanup!
Two of the flang tests don't pass. Please could you remove all of the changed
CHECK lines in `flang/Lower/array.f90` and `flang/Lower/module_use.f90`.
`array.f90` seems to have always been broken: `CHECK-LABEL` is enforcing an
@@ -285,7 +285,7 @@ define i32 @xunp(ptr %p) nounwind readnone {
; BMI264-NEXT:rorxl $7, (%rdi), %eax
; BMI264-NEXT:retq
entry:
-; shld-label: xunp:
+; shld-LABEL: xunp:
; shld: shldl $25
RKSimon wrote:
remove these 2 checks (the auto checks above
@@ -58,7 +58,7 @@ CHECK-CNT3-NOT: {{^}}this is duplicate
CHECK-CNT4-COUNT-5: this is duplicate
CHECK-CNT4-EMPTY:
-Many-label:
+Many-LABEL:
klensy wrote:
I think i changed this file accidentally in process of fixing other things,
i'll remove this
@@ -58,7 +58,7 @@ CHECK-CNT3-NOT: {{^}}this is duplicate
CHECK-CNT4-COUNT-5: this is duplicate
CHECK-CNT4-EMPTY:
-Many-label:
+Many-LABEL:
arsenm wrote:
I would be careful about touching FileCheck tests. The point might be the wrong
label
@@ -58,7 +58,7 @@ CHECK-CNT3-NOT: {{^}}this is duplicate
CHECK-CNT4-COUNT-5: this is duplicate
CHECK-CNT4-EMPTY:
-Many-label:
+Many-LABEL:
RoboTux wrote:
IMO this makes it harder to spot that this is *not* a FileCheck directive. I
think we should drop
https://github.com/daniel-grumberg approved this pull request.
LGTM to me for the ExtractAPI one.
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
klensy wrote:
> The Arm/AArch64 tests looks OK for the most part. I might be able to help
> with some of them if that is easier than trying to sort them all here.
It will be nice if you can list tests exactly so i can copy them into separate
pr; or if you prefer, you can copy them yourself.
@@ -189,15 +189,15 @@ define i32 @shr(i32 %a, i32 %b) {
define i1 @outer_and1(i1 %a) {
-; check-label: @outer_and1(
-; check-not: call i1 @and1
+; check-LABEL: @outer_and1(
davemgreen wrote:
I've regenerated the check lines in
@@ -121,7 +121,7 @@ define i32 @test_orr_extract_from_mul_1(i32 %x, i32 %y) {
; CHECK-THUMB-NEXT:orrs r0, r1
; CHECK-THUMB-NEXT:bx lr
entry:
-; CHECk-THUMB: orrs r0, r1
davemgreen wrote:
I believe we can delete this line, it was left in from the old
@@ -189,15 +189,15 @@ define i32 @shr(i32 %a, i32 %b) {
define i1 @outer_and1(i1 %a) {
-; check-label: @outer_and1(
-; check-not: call i1 @and1
+; check-LABEL: @outer_and1(
davemgreen wrote:
Should all these be "CHECK"?
@@ -217,42 +217,42 @@ define <4 x i32> @load_v3i8_to_4xi32_const_offset_3(ptr
%src) {
}
define <4 x i32> @volatile_load_v3i8_to_4xi32(ptr %src) {
-; check-label: volatile_load_v3i8_to_4xi32:
+; check-LABEL: volatile_load_v3i8_to_4xi32:
davemgreen wrote:
I
@@ -22,7 +22,7 @@ define signext i8 @test1(i32 %A) {
; CHECK-V7: @ %bb.0:
; CHECK-V7-NEXT:sbfx r0, r0, #8, #8
; CHECK-V7-NEXT:bx lr
-; CHECk-V7: sbfx r0, r0, #8, #8
+; CHECK-V7: sbfx r0, r0, #8, #8
davemgreen wrote:
I believe we can delete this
https://github.com/davemgreen commented:
The Arm/AArch64 tests looks OK for the most part. I might be able to help with
some of them if that is easier than trying to sort them all here.
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits
https://github.com/davemgreen edited
https://github.com/llvm/llvm-project/pull/91854
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
27 matches
Mail list logo
