https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
> Is there any additional work needed on this before it can be merged?
No, it looks good. I'll merge this.
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/ChuanqiXu9 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
davidstone wrote:
Is there any additional work needed on this before it can be merged?
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,7 +159,8 @@ class APINotesManager {
ArrayRef getCurrentModuleReaders() const {
bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-assert((!HasPrivate || HasPublic) && "private module
https://github.com/davidstone updated
https://github.com/llvm/llvm-project/pull/93417
>From 19b59231951b3ef48e36b0342f15d61687b72d8d Mon Sep 17 00:00:00 2001
From: David Stone
Date: Fri, 31 May 2024 09:40:02 -0600
Subject: [PATCH] [clang][Modules] Remove unnecessary includes of `Module.h`
---
https://github.com/ldionne approved this pull request.
libcxx/ changes LGTM.
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,7 +41,11 @@
#include
#include
-namespace clang::clangd {
+namespace clang {
+
+class Module;
kadircet wrote:
yes that's mostly something we try in clangd, but fair point, feel free to
ignore this one.
i was mostly pushing because this is just a
@@ -159,7 +159,8 @@ class APINotesManager {
ArrayRef getCurrentModuleReaders() const {
bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-assert((!HasPrivate || HasPublic) && "private module
@@ -42,7 +41,11 @@
#include
#include
-namespace clang::clangd {
+namespace clang {
+
+class Module;
davidstone wrote:
Specifically I'm following the guidance at:
https://llvm.org/docs/CodingStandards.html#include-as-little-as-possible
@@ -42,7 +41,11 @@
#include
#include
-namespace clang::clangd {
+namespace clang {
+
+class Module;
davidstone wrote:
Is that a clangd preference or llvm-wide? I see a lot of forward declarations
in other parts of the code so I want to understand when I
@@ -159,7 +159,8 @@ class APINotesManager {
ArrayRef getCurrentModuleReaders() const {
bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-assert((!HasPrivate || HasPublic) && "private module
https://github.com/kadircet requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -42,7 +41,11 @@
#include
#include
-namespace clang::clangd {
+namespace clang {
+
+class Module;
kadircet wrote:
this is not an "unnecessary" include, clangd requires a declaration of
`clang::Module` in this file (even if incomplete) and we try not to
https://github.com/kadircet edited
https://github.com/llvm/llvm-project/pull/93417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -159,7 +159,8 @@ class APINotesManager {
ArrayRef getCurrentModuleReaders() const {
bool HasPublic = CurrentModuleReaders[ReaderKind::Public];
bool HasPrivate = CurrentModuleReaders[ReaderKind::Private];
-assert((!HasPrivate || HasPublic) && "private module
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clangd
Author: David Stone (davidstone)
Changes
---
Patch is 28.19 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/93417.diff
10 Files
https://github.com/davidstone created
https://github.com/llvm/llvm-project/pull/93417
None
>From f4b9852b0c11a9b5087c5fdb7794b5cab7f4d22c Mon Sep 17 00:00:00 2001
From: David Stone
Date: Sun, 26 May 2024 10:34:09 -0600
Subject: [PATCH] [clang][Modules] Remove unnecessary includes of
18 matches
Mail list logo
