https://github.com/Bigcheese closed
https://github.com/llvm/llvm-project/pull/84423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dwblaikie wrote:
Cool cool - thanks for the extra context!
https://github.com/llvm/llvm-project/pull/84423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Bigcheese wrote:
The other cases of `std::system_category` were in `LLVM_ON_UNIX` (or similar)
blocks that would only be used on systems where it's mostly fine to use either
one, as most of the time you'll get an error that's in `std::errc`, and then
there's no difference (or they just are
https://github.com/dwblaikie approved this pull request.
Sounds OK to me.
(though several other instances of system_category are touched in this patch -
out of curiosity, how are those different from the one fixed case you called
out in JSONTransport.cpp? Are the other uses of system_category
llvmbot wrote:
@llvm/pr-subscribers-llvm-binary-utilities
Author: Michael Spencer (Bigcheese)
Changes
LLVM is inconsistent about how it converts `errno` to `std::error_code`. This
can cause problems because values outside of `std::errc` compare differently if
one is system and one is
https://github.com/Bigcheese created
https://github.com/llvm/llvm-project/pull/84423
LLVM is inconsistent about how it converts `errno` to `std::error_code`. This
can cause problems because values outside of `std::errc` compare differently if
one is system and one is generic on POSIX systems.
