ChuanqiXu9 wrote:
I'd like to close this since the issue got closed.
https://github.com/llvm/llvm-project/pull/81919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/81919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
h-vetinari wrote:
> A test will be helpful for us to understand what happened.
There's a reproducer in https://github.com/llvm/llvm-project/issues/80570
https://github.com/llvm/llvm-project/pull/81919
___
cfe-commits mailing list
https://github.com/ChuanqiXu9 requested changes to this pull request.
This is not wanted. While we have a policy to revert patches if the patches
break existing codes, the C++20 modules support in clangd is literally broken:
https://github.com/clangd/clangd/issues/1293
Also the ability to
https://github.com/CLRN updated https://github.com/llvm/llvm-project/pull/81919
>From dae725e0c48837a18aa9b90945de0b86a33890ff Mon Sep 17 00:00:00 2001
From: clrn
Date: Thu, 15 Feb 2024 20:41:34 +
Subject: [PATCH] [clangd] Fix C++20 modules crash
This fix partially reverts
poyaoc97 wrote:
cc @ChuanqiXu9
https://github.com/llvm/llvm-project/pull/81919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
@llvm/pr-subscribers-clang
Author: None (CLRN)
Changes
This fix partially reverts
https://github.com/llvm/llvm-project/commit/a0b6747804e46665ecfd00295b60432bfe1775b6.
The serialization part is restored to the state prior to the
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you,
https://github.com/CLRN created https://github.com/llvm/llvm-project/pull/81919
This fix partially reverts
https://github.com/llvm/llvm-project/commit/a0b6747804e46665ecfd00295b60432bfe1775b6.
The serialization part is restored to the state prior to the mentioned commit
as it causing issue
