[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -216,6 +216,9 @@ Improvements to Clang's diagnostics - The fix-it emitted by ``-Wformat`` for scoped enumerations now take the enumeration's underlying type into account instead of suggesting a type just based on the format string specifier being used. +-

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/3] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/erichkeane commented: I believe this needs a release note as well (see docs/ReleaseNotes.rst), else this LGTM. https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec , else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/2] [diag] Silence `-Wfixed-enum-extension` in C23 The C23

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec , else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

llvmbot wrote: @llvm/pr-subscribers-clang Changes The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1]

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/68060 The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1]