https://github.com/Meinersbur closed
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Meinersbur wrote:
> IIRC it was unnecessary for the documentation because it gets built multiple
> times, for the driver it's built once so it has to include all possible
> variants the first time.
>
> I have no preference for how it's done, if the `%Program` thing works then
> fine. We only
https://github.com/luporl approved this pull request.
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/banach-space approved this pull request.
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tblah approved this pull request.
The changes in this PR look good to me. Thanks for the fix!
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
banach-space wrote:
> Would you like me to introduce DocBriefForVariants?
+1 That would be helpful for `-I`:
*
https://flang.llvm.org/docs/FlangCommandLineReference.html#cmdoption-flang-I-dir
Ideally we'd find more examples (so that you are not adding it for just one
option).
As for this:
https://github.com/DavidSpickett approved this pull request.
The changes themselves LGTM, thanks for fixing this.
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
DavidSpickett wrote:
> The docbrief strings already use %Program/GlobalDocumentation.Program which
> seems to work and made me think that HelpTextForVariants was actually
> unnecessary. Would you like me to introduce DocBriefForVariants?
IIRC it was unnessecary for the documentation because
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"],
"gcc-install-dir=">,
"Note: executables (e.g. ld) used by the compiler are not overridden by the
selected GCC installation">;
def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>,
Meinersbur wrote:
> Do you mean that this PR fixes this, or that you noticed this problem while
> working on this?
I noticed this when working on the patch, .i.e that
https://flang.llvm.org/docs/FlangCommandLineReference.html still mentioned
Clang in several places and since it was common, I
banach-space wrote:
> > Clang is also mentioned for the diagnostic warnings reference, which mostly
> > applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this, and
> > I don't know a better solution.
>
> Do you mean that this PR fixes this, or that you noticed this problem
DavidSpickett wrote:
> Clang is also mentioned for the diagnostic warnings reference, which mostly
> applies to C/C++/Obj-C, not Fortran.
> https://github.com/llvm/llvm-project/pull/81726 already tried to fix this,
> and I don't know a better solution.
Do you mean that this PR fixes this, or
@@ -807,8 +807,12 @@ def gcc_install_dir_EQ : Joined<["--"],
"gcc-install-dir=">,
"Note: executables (e.g. ld) used by the compiler are not overridden by the
selected GCC installation">;
def gcc_toolchain : Joined<["--"], "gcc-toolchain=">, Flags<[NoXarchOption]>,
https://github.com/banach-space approved this pull request.
Nice, thank you! LGTM
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-flang-driver
Author: Michael Kruse (Meinersbur)
Changes
The help text was not updated in #87360.
Clang is also mentioned for the diagnostic warnings reference, which mostly
applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this,
and I
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Kruse (Meinersbur)
Changes
The help text was not updated in #87360.
Clang is also mentioned for the diagnostic warnings reference, which mostly
applies to C/C++/Obj-C, not Fortran. #81726 already tried to fix this,
and I don't
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Meinersbur edited
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
18 matches
Mail list logo
