jhuber6 wrote:
@vvereschaka Should be fixed now.
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
> @jhuber6 , looks like these changes break the following builds
>
> * https://lab.llvm.org/buildbot/#/builders/235/builds/5630
>
> * https://lab.llvm.org/buildbot/#/builders/232/builds/19808
>
>
> there are a lot of CMake error messages started with
>
> ```
> CMake
vvereschaka wrote:
@jhuber6 ,
looks like these changes break the following builds
* https://lab.llvm.org/buildbot/#/builders/235/builds/5630
* https://lab.llvm.org/buildbot/#/builders/232/builds/19808
there are a lot of CMake error messages started with
```
CMake Error at
https://github.com/jhuber6 closed
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From c118c0b82cf47b36460479fd920325dedc7a6c79 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 575390d65fd35729e855823e38dfd28f7a15debd Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 2cf6f184e2e8a6abc31e0dfb19c706569357597d Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/JonChesterfield dismissed
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JonChesterfield commented:
Stalled on https://github.com/llvm/llvm-project/pull/81557, trying to remove
the approve mark as otherwise i'll forget about this
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing
https://github.com/JonChesterfield approved this pull request.
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
JonChesterfield wrote:
OK, worked through this patch now. The noise is substantial but it's an
improvement on what we have - the overall impression is that the cmake was
originally very special cased for GPUs and now treats them very similarly to
other targets, with some careful footwork
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From a396fe930db6c3fb20dc4f7918736e54d21cb24b Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
JonChesterfield wrote:
One large patch may be necessary - is it also necessary to interleave
reordering files with changing the contents? It makes the GUI diff tool we're
using here essentially useless. If the moving code between files and factoring
into functions was a separate commit we'd
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -50,31 +50,9 @@ function(collect_object_file_deps target result)
endif()
endfunction(collect_object_file_deps)
-# A rule to build a library from a collection of entrypoint objects.
-# Usage:
-# add_entrypoint_library(
-# DEPENDS
-# )
-#
-# NOTE: If one
@@ -50,31 +50,9 @@ function(collect_object_file_deps target result)
endif()
endfunction(collect_object_file_deps)
-# A rule to build a library from a collection of entrypoint objects.
-# Usage:
-# add_entrypoint_library(
-# DEPENDS
-# )
-#
-# NOTE: If one
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From f3013086f60f2a78c12887cf1736455e8fb1911b Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 8727a9631480deac9d9df386ed26dfcd35914a13 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 85f7218baa72307699b48bffa3da4005597ec719 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jplehr commented:
I looked at the changes and from the little I understand CMake they seem ok.
I added one nit.
Maybe @saiislam can have a look as well.
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
https://github.com/jplehr edited https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -102,6 +80,121 @@ function(add_entrypoint_library target_name)
list(APPEND all_deps ${entrypoint_target})
endforeach(dep)
list(REMOVE_DUPLICATES all_deps)
+ set(${result} ${all_deps} PARENT_SCOPE)
+endfunction()
+
+# A rule to build a library from a collection of
jhuber6 wrote:
Tested this one a few machines and it works as expected after some final tweaks.
FYI @jplehr and @Artem-B, this will change the CMake configuration required for
building and testing on the build bots. The new expected way to test each one
respectively would be the following
```
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 63e4205a9f5cc3ea8a4ce0730b01d78b6c9bde42 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From c4758c8663307708e5ac653a8692e595f4b1f4cc Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
@@ -135,86 +147,20 @@ function(_get_common_test_compile_options output_var
flags)
# list(APPEND compile_options "-Wglobal-constructors")
# endif()
endif()
- if (LIBC_TARGET_ARCHITECTURE_IS_GPU)
-# TODO: Set these flags
-# list(APPEND compile_options
@@ -135,86 +147,20 @@ function(_get_common_test_compile_options output_var
flags)
# list(APPEND compile_options "-Wglobal-constructors")
# endif()
endif()
- if (LIBC_TARGET_ARCHITECTURE_IS_GPU)
-# TODO: Set these flags
-# list(APPEND compile_options
@@ -135,86 +147,20 @@ function(_get_common_test_compile_options output_var
flags)
# list(APPEND compile_options "-Wglobal-constructors")
# endif()
endif()
- if (LIBC_TARGET_ARCHITECTURE_IS_GPU)
-# TODO: Set these flags
-# list(APPEND compile_options
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 3c4a7ea70941fbf3c8a47c0715423ae38cc25a68 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From d0f782f4db249f6be08dba5060ee403974c95fdf Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From caf0ee274f353b6adb23c455121ec2102c260de0 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
@@ -1,12 +1,9 @@
set(libc_archive_targets "")
+ list(APPEND added_archive_targets ${archive_1})
jhuber6 wrote:
Don't know how that got there, I'll fix it.
https://github.com/llvm/llvm-project/pull/81921
___
@@ -533,15 +542,14 @@ endfunction(add_integration_test)
set(LIBC_HERMETIC_TEST_COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_DEFAULT}
michaelrj-google wrote:
it should be just the part here and the part relating to compile options in
libc object rules
@@ -533,15 +542,14 @@ endfunction(add_integration_test)
set(LIBC_HERMETIC_TEST_COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_DEFAULT}
jhuber6 wrote:
Yeah there's a lot of logic that's moved and broken after rebasing. Trying to
figure out what's changed.
@@ -533,15 +542,14 @@ endfunction(add_integration_test)
set(LIBC_HERMETIC_TEST_COMPILE_OPTIONS ${LIBC_COMPILE_OPTIONS_DEFAULT}
michaelrj-google wrote:
this section was moved into `LLVMLibcCCompileOptionRules.cmake` in
@@ -1,12 +1,9 @@
set(libc_archive_targets "")
+ list(APPEND added_archive_targets ${archive_1})
michaelrj-google wrote:
I don't think this is in the right place since `archive_1` is defined below.
https://github.com/llvm/llvm-project/pull/81921
https://github.com/michaelrj-google commented:
Overall LGTM from the libc side
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/michaelrj-google edited
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 613402be5f027c7f5494513772d0f17dd046a3e8 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
https://github.com/jhuber6 edited
https://github.com/llvm/llvm-project/pull/81921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/81921
>From 5fdaa384ebc962429950b79098dee0581c74f4f3 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Tue, 13 Feb 2024 21:08:02 -0600
Subject: [PATCH] [libc] Rework the GPU build to be a regular target
Summary:
This
llvmbot wrote:
@llvm/pr-subscribers-backend-amdgpu
Author: Joseph Huber (jhuber6)
Changes
Summary:
This is a massive patch because it reworks the entire build and
everything that depends on it. This is not split up because various bots
would fail otherwise. I will attempt to describe the
https://github.com/jhuber6 created
https://github.com/llvm/llvm-project/pull/81921
Summary:
This is a massive patch because it reworks the entire build and
everything that depends on it. This is not split up because various bots
would fail otherwise. I will attempt to describe the necessary
43 matches
Mail list logo