[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google resolved https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra edited https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/sivachandra commented: Few nits, but otherwise OK. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf sivachandra wrote: I think it was removed because it is listed on line 130 also.

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/jhuber6 commented: The changes make sense to me overall with some nits. https://github.com/llvm/llvm-project/pull/66023 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -9,44 +9,61 @@ #ifndef LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H #define LLVM_LIBC_SRC_STDIO_SCANF_CORE_READER_H -#include "src/stdio/scanf_core/file_reader.h" -#include "src/stdio/scanf_core/string_reader.h" +#include "src/__support/macros/attributes.h" // For LIBC_INLINE

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -126,6 +126,10 @@ set(TARGET_LIBC_ENTRYPOINTS libc.src.stdio.snprintf libc.src.stdio.vsprintf libc.src.stdio.vsnprintf +#TODO: Check if scanf can be enabled on aarch64 jhuber6 wrote: Seems like this should be tested first.

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

@@ -439,10 +442,6 @@ if(LLVM_LIBC_FULL_BUILD) libc.src.stdio.getc_unlocked libc.src.stdio.getchar libc.src.stdio.getchar_unlocked -libc.src.stdio.printf jhuber6 wrote: Does this accidentally delete `printf`?

[clang] [libc] Refactor scanf reader to match printf (PR #66023)

https://github.com/michaelrj-google updated https://github.com/llvm/llvm-project/pull/66023: >From c6330fb734a687d975dc2c6e674d98b03d8f2d1b Mon Sep 17 00:00:00 2001 From: Michael Jones Date: Mon, 11 Sep 2023 15:22:15 -0700 Subject: [PATCH] [libc] Refactor scanf reader to match printf In a