eaeltsin wrote:
> #80050 opened. Nevertheless, a reproducer for future work would be
> appreciated.
I'm running a reduction, but it progresses extremely slowly. Will post as soon
as it converges to something meaningful (or I'll get some time to reduce the
test case by hand).
https://github.
bolshakov-a wrote:
#80050 opened. Nevertheless, a reproducer for future work would be appreciated.
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/c
@@ -8129,29 +8067,133 @@
Sema::BuildExpressionFromIntegralTemplateArgument(const TemplateArgument &Arg,
else
Kind = CharacterLiteralKind::Ascii;
-E = new (Context) CharacterLiteral(Arg.getAsIntegral().getZExtValue(),
- Kind,
erichkeane wrote:
I see now that hte problem is probably in the Analyzer, so @steakhal is
probably the best person to be leading this, but any work you can do
@bolshakov-a would also likely be appreciated.
https://github.com/llvm/llvm-project/pull/78041
erichkeane wrote:
@bolshakov-a : The original bug has a good amount of analysis to it, so if you
could see if there is a fix for it, else we probably do have to revert for that
one and miss 18 with this patch.
https://github.com/llvm/llvm-project/pull/78041
steakhal wrote:
FYI this caused a crash in the Static Analyzer, tracked here: #79575
We will (well, probably I will) look into this to see what could be done about
it to workaround/fix the crash for clang-18.
https://github.com/llvm/llvm-project/pull/78041
__
bolshakov-a wrote:
Thank you all, especially to @zygoloid for allowing me to steal its thunder!
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
bolshakov-a wrote:
> Do you need me to merge that for you?
Yes, please. I don't have commit access.
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman commented:
Ping @rjmccall for Itanium mangling expertise to make sure we're matching the
spec.
There are a few merge conflicts that also cropped up which need to be resolved,
but overall I think this is pretty close to ready to try to re-land. It would
be nice
@@ -14,6 +14,11 @@
#include "clang/AST/ODRHash.h"
+#include "clang/AST/APValue.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/AST/CharUnits.h"
+#include "clang/AST/Decl.h"
+#include "clang/AST/DeclCXX.h"
bolshakov-a wrote:
Removed.
https://github.co
@@ -25,10 +25,13 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/Attr.h"
#include "clang/AST/DeclObjC.h"
+#include "clang/AST/Expr.h"
#include "clang/AST/NSAPI.h"
#include "clang/AST/StmtVisitor.h"
+#include "clang/AST/Type.h"
#include "clang/Basic/Builtins.h"
#inc
https://github.com/bolshakov-a updated
https://github.com/llvm/llvm-project/pull/78041
>From 459f2c778d42fd5132bf69695537dc5f5a26b160 Mon Sep 17 00:00:00 2001
From: Andrey Ali Khan Bolshakov
Date: Sun, 6 Aug 2023 19:38:23 +0300
Subject: [PATCH] [c++20] P1907R1: Support for generalized non-type
@@ -12,6 +12,7 @@
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/DeclVisitor.h"
+#include "clang/AST/ODRHash.h"
bolshakov-a wrote:
Just to clarify: do you insist that `#include` set added in a PR should be
minimal for c
bolshakov-a wrote:
Btw, I have a local branch with a few distinct commits. I could temporarily
push it to simplify review process, and then squash them before merging.
https://github.com/llvm/llvm-project/pull/78041
___
cfe-commits mailing list
cfe-co
@@ -25,10 +25,13 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/Attr.h"
#include "clang/AST/DeclObjC.h"
+#include "clang/AST/Expr.h"
#include "clang/AST/NSAPI.h"
#include "clang/AST/StmtVisitor.h"
+#include "clang/AST/Type.h"
#include "clang/Basic/Builtins.h"
#inc
@@ -80,6 +81,13 @@ class TemplateArgument {
/// that was provided for an integral non-type template parameter.
Integral,
+/// The template argument is a non-type template argument that can't be
+/// represented by the special-case Declaration, NullPtr, or Integ
@@ -12,6 +12,7 @@
#include "clang/AST/DeclCXX.h"
#include "clang/AST/DeclTemplate.h"
#include "clang/AST/DeclVisitor.h"
+#include "clang/AST/ODRHash.h"
cor3ntin wrote:
Is the header necessary?
https://github.com/llvm/llvm-project/pull/78041
__
@@ -25,10 +25,13 @@
#include "clang/AST/ASTContext.h"
#include "clang/AST/Attr.h"
#include "clang/AST/DeclObjC.h"
+#include "clang/AST/Expr.h"
#include "clang/AST/NSAPI.h"
#include "clang/AST/StmtVisitor.h"
+#include "clang/AST/Type.h"
#include "clang/Basic/Builtins.h"
#inc
19 matches
Mail list logo