cjappl wrote:
Thanks for your help! You were correct that cc was pointing to gcc. This is
fixed when I updated my machine to use my known clang as the default compiler.
For future archeologists, this meant (from [this
answer](https://askubuntu.com/questions/1198087/how-to-set-clang-9-as-the-de
Endilll wrote:
Yes, some try_compile checks where replaced with a check for
`CMAKE_CXX_COMPILER_ID`, so it's crucial for it to reflect the reality.
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaskRay wrote:
> Hi @Endilll
>
> I did a git bisect that pointed to this change as the one blocking my
> compilation on an Ubuntu docker image with clang 14.0
>
> The error I see:
>
> ```
> CMake Error at
> /test_radsan/llvm-project/compiler-rt/cmake/Modules/CheckSectionExists.cmake:72
> (m
cjappl wrote:
Hi @Endilll
I did a git bisect that pointed to this change as the one blocking my
compilation on an Ubuntu docker image with clang 14.0
The error I see:
```
CMake Error at
/test_radsan/llvm-project/compiler-rt/cmake/Modules/CheckSectionExists.cmake:72
(message):
cc: error:
Endilll wrote:
@vvereschaka Thank you for letting me know! I wonder how this got past our pre-
and post-commit CI, because we do build lldb with MSVC there. You fix makes
total sense, so I applied it.
https://github.com/llvm/llvm-project/pull/92953
_
vvereschaka wrote:
Hi @Endilll ,
these changes break MSVC build of the projects including LLDB. The `cl`
compiler gets unsupported gcc/clang options, such as
`-Wno-deprecated-declarations`, `-Wno-unknown-pragmas` and
`-Wno-strict-aliasing`, and gets failed because of it.
Here is the command
Endilll wrote:
I think the issue is that we no longer passed `-fno-lifetime-dse` to GCC due to
incorrect condition (my fault), which caused some downstream LTO crashes as
reported by @mveriksson in
https://github.com/llvm/llvm-project/commit/4feae05c6abda364a9295aecfa600d7d4e7dfeb6#r142466703
nikic wrote:
> > FYI this causes a minor compile-time improvement in stage1 builds using
> > gcc:
> > https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u
> > While that's nice, it does s
Endilll wrote:
> FYI this causes a minor compile-time improvement in stage1 builds using gcc:
> https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u
> While that's nice, it does suggest th
felipepiovezan wrote:
These types of changes touching a lot of projects at once can benefit from
multiple PRs, one per project, as it makes partial reverts a lot easier and
doesn't cause as much churn downstream (plus we can get more targeted comments
from individual project owners)
https://g
nikic wrote:
FYI this causes a minor compile-time improvement in stage1 builds using gcc:
https://llvm-compile-time-tracker.com/compare.php?from=32c3561d44aa792ef08d72b5a4c342c9965bc4c2&to=4feae05c6abda364a9295aecfa600d7d4e7dfeb6&stat=instructions:u
While that's nice, it does suggest that the f
Endilll wrote:
Quite expectedly, I see buildbot failures. Working on them.
https://lab.llvm.org/buildbot/#/builders/36/builds/45836
https://lab.llvm.org/buildbot/#/builders/57/builds/35200
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits
https://github.com/Endilll closed
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92953
>From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 21 May 2024 21:41:24 +0300
Subject: [PATCH 1/3] Remove some `try_compile` CMake checks for compiler flag
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/92953
>From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 21 May 2024 21:41:24 +0300
Subject: [PATCH 1/2] Remove some `try_compile` CMake checks for compiler flag
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aeubanks approved this pull request.
awesome, thanks!
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
Great 👍
https://github.com/llvm/llvm-project/pull/92953
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
Here are CE links with the set of minimum required compilers that should cover
almost all the changes I made:
https://godbolt.org/z/j98xzhrGa
https://godbolt.org/z/errv4WhfP
https://godbolt.org/z/vnoh8YqEP
Windows-targeted flags were tested both on MSVC on CE, and on clang-cl 5.0
Endilll wrote:
On my setup, this patch improves CMake configuration times (from a clean state)
from 51 seconds down to 46 seconds (average of 3 measurements).
My setup: ancient x86 hardware, Debian Sid, nightly Clang, build directory on a
RAM disk. CMake invocation:
`cmake -DLLVM_ENABLE_PROJEC
llvmbot wrote:
@llvm/pr-subscribers-lldb
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch remove 36 checks for compiler flags that are done via invoking the
compiler across LLVM, Clang, and LLDB. It's was made possible by raising the
bar for supported co
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/92953
This patch remove 36 checks for compiler flags that are done via invoking the
compiler across LLVM, Clang, and LLDB. It's was made possible by raising the
bar for supported compilers that has been happening over
23 matches
Mail list logo
