[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/chapuni closed https://github.com/llvm/llvm-project/pull/81221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81221 >From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Fri, 9 Feb 2024 07:56:51 +0900 Subject: [PATCH 1/4] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81221 >From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Fri, 9 Feb 2024 07:56:51 +0900 Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/evodius96 approved this pull request. https://github.com/llvm/llvm-project/pull/81221 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

chapuni wrote: @evodius96 As an experiment, I've made subscripts as `bool`. It works semantically however I wonder they wouldn't be intuitive to us. I can rewind it. https://github.com/llvm/llvm-project/pull/81221 ___ cfe-commits mailing list cfe-com

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; chapuni wrote: `first` and `second` didn't make sense to me. https://github.com/llvm/llvm-projec

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/chapuni updated https://github.com/llvm/llvm-project/pull/81221 >From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001 From: NAKAMURA Takumi Date: Fri, 9 Feb 2024 07:56:51 +0900 Subject: [PATCH 1/3] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; evodius96 wrote: Ah, well it's iterable. https://github.com/llvm/llvm-project/pull/81221 ___

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

@@ -217,6 +217,9 @@ class CounterExpressionBuilder { using LineColPair = std::pair; +using MCDCConditionID = unsigned int; +using MCDCConditionIDs = std::array; evodius96 wrote: is `std::array<>` better than `std::pair<>` when it only has two elements? http

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

llvmbot wrote: @llvm/pr-subscribers-clang Author: NAKAMURA Takumi (chapuni) Changes Its 0th element corresponds to `FalseID` and 1st to `TrueID`. CoverageMappingGen.cpp: `DecisionIDPair` is replaced with `ConditionIDs` --- Full diff: https://github.com/llvm/llvm-project/pull/81221.diff

[clang] [llvm] [MC/DC] Refactor: Introduce `ConditionIDs` as `std::array<2>` (PR #81221)

https://github.com/chapuni created https://github.com/llvm/llvm-project/pull/81221 Its 0th element corresponds to `FalseID` and 1st to `TrueID`. CoverageMappingGen.cpp: `DecisionIDPair` is replaced with `ConditionIDs` >From 66bb6cc3fd339360c16c6a98ce08f34978f665e0 Mon Sep 17 00:00:00 2001 From