MaskRay wrote:
The current patch doesn't do what the title implies ("Always emit relocations
for resolved ").
https://github.com/llvm/llvm-project/pull/73793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
andcarminati wrote:
> For the driver BareMetal.cpp change, claiming `-mno-relax` should not be done
> for non-RISCV targets (e.g. AArch32).
Thank you for the update. I updated the PR reverting the backend part and
addressing this issue just for RISC-V.
https://github.com/andcarminati updated
https://github.com/llvm/llvm-project/pull/73793
>From a7ba3e4e7a84c49e80fe3e05c1a8ca83e7fd8c6e Mon Sep 17 00:00:00 2001
From: Andreu Carminati
Date: Tue, 28 Nov 2023 15:26:49 +0100
Subject: [PATCH 1/2] [RISCV][MC] Always emit relocations for resolved
MaskRay wrote:
For the driver BareMetal.cpp change, claiming `-mno-relax` should not be done
for non-RISCV targets (e.g. AArch32).
https://github.com/llvm/llvm-project/pull/73793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
jrtc27 wrote:
> Also, we cannot trust Subtarget features here, because it may be empty in
> case of LTO codegen, preventing relaxations.
And that's the problem. It's vital that we have the information. Anything else
is just a hack that papers over the fundamental issue.
jrtc27 wrote:
As far as I can tell this is pointless. If you want relaxation you need
R_RISCV_RELAX and R_RISC_ALIGN relocations to be emitted. If you don't want
relaxation you don't need these. Therefore it seems like all this does is emit
a whole bunch of useless relocations for the case
https://github.com/andcarminati edited
https://github.com/llvm/llvm-project/pull/73793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
