aheejin wrote:
I guess you've likely already found it but anyway it's here:
https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access
It's basically "Email Chris".
https://github.com/llvm/llvm-project/pull/93228
___
cfe-commits mailing list
c
https://github.com/aheejin closed
https://github.com/llvm/llvm-project/pull/93228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
brendandahl wrote:
> LGTM % `!HasHalfPrecision` thing
>
> By the way I guess you can try getting commit access soon? I think it is
> still "Send an email to Chris" though...
Done, can I get a squash and merge?
I'll look into getting commit access.
https://github.com/llvm/llvm-project/pull/93
https://github.com/aheejin edited
https://github.com/llvm/llvm-project/pull/93228
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brendandahl updated
https://github.com/llvm/llvm-project/pull/93228
>From 28cc678038feefffceba8cbe24349e1885b24c75 Mon Sep 17 00:00:00 2001
From: Brendan Dahl
Date: Tue, 21 May 2024 21:15:14 +
Subject: [PATCH 1/2] [WebAssembly] Implement prototype f16x8.splat
instruction
https://github.com/aheejin approved this pull request.
LGTM % `!HasHalfPrecision` thing
By the way I guess you can try getting a commit access soon? I think it is
still "Send an an email to Chris" though...
https://github.com/llvm/llvm-project/pull/93228
___
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string &Name) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
aheejin wr
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string &Name) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
brendandah
@@ -90,6 +90,7 @@ class LLVM_LIBRARY_VISIBILITY WebAssemblyTargetInfo : public
TargetInfo {
StringRef getABI() const override;
bool setABI(const std::string &Name) override;
+ bool useFP16ConversionIntrinsics() const override { return false; }
dschuff wr
https://github.com/brendandahl updated
https://github.com/llvm/llvm-project/pull/93228
>From 28cc678038feefffceba8cbe24349e1885b24c75 Mon Sep 17 00:00:00 2001
From: Brendan Dahl
Date: Tue, 21 May 2024 21:15:14 +
Subject: [PATCH] [WebAssembly] Implement prototype f16x8.splat instruction.
Ad
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff dd2d132fb3521f37f44656edd65cca75430c251e
002e33294cae26796ca79a66dbd275f3e26807d2 --
brendandahl wrote:
cc @aheejin @dschuff
As mentioned in the meeting, it looks like it will be a lot more work to get
half value's working with normal patterns, so for now I'll stick to just
built-ins and intrinsics.
https://github.com/llvm/llvm-project/pull/93228
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Brendan Dahl (brendandahl)
Changes
Adds a builtin and intrinsic for the f16x8.splat instruction.
Specified at:
https://github.com/WebAssembly/half-precision/blob/29a9b9462c9285d4ccc1a5dc39214ddfd1892658/proposals/half-precision/Overview.md
N
https://github.com/brendandahl created
https://github.com/llvm/llvm-project/pull/93228
Adds a builtin and intrinsic for the f16x8.splat instruction.
Specified at:
https://github.com/WebAssembly/half-precision/blob/29a9b9462c9285d4ccc1a5dc39214ddfd1892658/proposals/half-precision/Overview.md
No
14 matches
Mail list logo
