artemcm wrote:
> Clang test now looks good to me. Might be nice to drop
> `InstrumentingInMemoryFilesystem` in favor of the existing
> `InstrumentingFilesystem` (that I added just moments ago, sorry!) wrapped
> around a normal `InMemoryFileSystem`, but I'm happy to do that myself in a
> follo
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From 8164aaf2e93dde4761789e6d574088d1cb0e97fc Mon Sep 17 00:00:00 2001
From: Artem Chikin
Date: Tue, 9 Apr 2024 09:37:09 -0700
Subject: [PATCH] [clang][deps] Overload 'Filesystem::exists' in
'DependencyScanning
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From e010a761a34692e5ca1959fc9022d0950e669664 Mon Sep 17 00:00:00 2001
From: Artem Chikin
Date: Tue, 9 Apr 2024 09:37:09 -0700
Subject: [PATCH] [clang][deps] Overload 'Filesystem::exists' in
'DependencyScanning
jansvoboda11 wrote:
Clang test now looks good to me. Might be nice to drop
`InstrumentingInMemoryFilesystem` in favor of the existing
`InstrumentingFilesystem` (that I added just moments ago, sorry!) wrapped
around a normal `InMemoryFileSystem`, but I'm happy to do that myself in a
follow-up
jansvoboda11 wrote:
I assume clang-format was overly eager with this one, as these are just
whitespace changes. Can we undo that?
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commi
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From 24e869df273b9d75bb4fdf85f4ee8ab2ddbccc2c Mon Sep 17 00:00:00 2001
From: Artem Chikin
Date: Tue, 9 Apr 2024 09:37:09 -0700
Subject: [PATCH] [clang][deps] Overload 'Filesystem::exists' in
'DependencyScanning
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From 12621dc6344335375ac1a5c806d778f1ed15a5ce Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
jansvoboda11 wrote:
Please apply the code formatting suggestions.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,51 @@
+//===- DependencyScanningFilesystemTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5601e35f620eccdebab988bed4b9677b29366b79
2c9430526320b815f8722512f141e7a90f1c5eb1 --
aganea wrote:
> In the meantime, are you able to work around this for your non-modular
> use-case by applying your change when building your own compiler downstream?
Yes I fixed it in our downstream. I am more worried about other users, since
the initial version that @hyp committed a while ago
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -270,6 +270,12 @@ DependencyScanningWorkerFilesystem::status(const Twine
&Path) {
return Result->getStatus();
}
+bool
+DependencyScanningWorkerFilesystem::exists(const Twine &Path) {
+ llvm::ErrorOr Status = status(Path);
jansvoboda11 wrote:
The one fr
@@ -270,6 +270,12 @@ DependencyScanningWorkerFilesystem::status(const Twine
&Path) {
return Result->getStatus();
}
+bool
+DependencyScanningWorkerFilesystem::exists(const Twine &Path) {
+ llvm::ErrorOr Status = status(Path);
artemcm wrote:
Which optimizat
@@ -0,0 +1,51 @@
+//===- DependencyScanningFilesystemTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
jansvoboda11 wrote:
@aganea Ah, got it. Unfortunately, caching stat failures for all directories
doesn't work for modules. Clang is supposed to create the modules cache
directory if one doesn't exist. But if we first cache its non-existence, Clang
will never see it again, even after Clang itse
aganea wrote:
> > Not sure @jansvoboda11 perhaps if we want to cherry pick
> > [b768a8c](https://github.com/llvm/llvm-project/commit/b768a8c1db85b9e84fd8b356570a3a8fbe37acf6)
> > on `release/18.x`? Or should we land just a simple PR with just the
> > function change above?
>
> I can try pulli
@@ -270,6 +270,12 @@ DependencyScanningWorkerFilesystem::status(const Twine
&Path) {
return Result->getStatus();
}
+bool
+DependencyScanningWorkerFilesystem::exists(const Twine &Path) {
+ llvm::ErrorOr Status = status(Path);
jansvoboda11 wrote:
Would be g
@@ -0,0 +1,51 @@
+//===- DependencyScanningFilesystemTest.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/jansvoboda11 requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jansvoboda11 wrote:
Seems like some tests failed on Linux.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jansvoboda11 approved this pull request.
LGTM. Would be nice to land Ben's change separately.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
artemcm wrote:
> I'd like to see a unit test specific to `DependencyScanningFilesystem`,
> similar to what I have here: #68645.
Done! Added one in `DependencyScanningFilesystemTest.cpp`. Thank you.
https://github.com/llvm/llvm-project/pull/88152
___
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
jansvoboda11 wrote:
I'd like to see a unit test specific to `DependencyScanningFilesystem`, similar
to what I have here: https://github.com/llvm/llvm-project/pull/68645.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-
jansvoboda11 wrote:
> Not sure @jansvoboda11 perhaps if we want to cherry pick
> [b768a8c](https://github.com/llvm/llvm-project/commit/b768a8c1db85b9e84fd8b356570a3a8fbe37acf6)
> on `release/18.x`? Or should we land just a simple PR with just the function
> change above?
I can try pulling b76
@@ -201,6 +201,21 @@ class ErrorDummyFileSystem : public DummyFileSystem {
}
};
+/// A version of \c DummyFileSystem that aborts on \c status() to test that
+/// \c exists() is being used.
+class NoStatusDummyFileSystem : public DummyFileSystem {
+public:
+ ErrorOr status(c
https://github.com/aganea approved this pull request.
Otherwise this PR LGTM.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aganea wrote:
> This patch doesn`t improve my usage, it seems I'm hitting a different
> codepath than you do. I'll investigate.
Ah I see, the commit
https://github.com/llvm/llvm-project/commit/b768a8c1db85b9e84fd8b356570a3a8fbe37acf6
didn't make it in time for the 18.x branch. The issue I'm s
aganea wrote:
This patch doesn`t improve my usage, it seems I'm hitting a different codepath
than you do. I'll investigate.
https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
@@ -270,6 +270,12 @@ DependencyScanningWorkerFilesystem::status(const Twine
&Path) {
return Result->getStatus();
}
+bool
+DependencyScanningWorkerFilesystem::exists(const Twine &Path) {
+ auto Status = status(Path);
aganea wrote:
The return type is unclea
https://github.com/aganea commented:
Thanks for the change! Quite interestingly I was just looking precisely at this
issue today :smile: Things are worst on Windows, where mini-filter drivers
kick-in and bring performance to its knees. I'll try your patch, see how that
improves my usage!
http
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/88152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From c2b2cd03e1d8f92b1df814e6312158b8820b790d Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Tue, 9 Apr 2024 11:22:44 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88152
>From fdf95d6c9186b91cf39a988e3baaa21a9cabe6a1 Mon Sep 17 00:00:00 2001
From: Ben Langmuir
Date: Thu, 6 Oct 2022 15:58:23 -0700
Subject: [PATCH 1/2] [llvm][vfs] Make vfs::FileSystem::exists() virtual NFC
Allow a
43 matches
Mail list logo