[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Thanks @AaronBallman, the patch is recommitted. https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Hi @AaronBallman and @nikic, are you happy for me to recommit the change? Thanks https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Hi @AaronBallman, Thanks so much for the explanation using an example. I now understand. I have updated the patch in the commit https://github.com/llvm/llvm-project/pull/65268/commits/f66e7d2b720692e9bc4bbc915de286f6de87e291. Kind regards, Maggie

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From 5b750383cace7db24144d16ce8a9ca0864c37613 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/2] [Clang] Add two time-trace scope variables. A time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

AaronBallman wrote: > Hi @nikic, thanks for spotting the issue and reverted the commit. > > Hi @AaronBallman, > > As @nikic mentioned that the issue is that the used strings may be expensive > to compute. If we remove the change to record the function name and function > location, I think

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Hi @nikic, thanks for spotting the issue and reverted the commit. Hi @AaronBallman, As @nikic mentioned that the issue is that the used strings may be expensive to compute. If we remove the change to record the function name and function location, I think the issue will

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi reopened https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

nikic wrote: I've reverted this change because it causes a large compile-time regression: http://llvm-compile-time-tracker.com/compare.php?from=61b9176cf70444c54f3ac6eebd82fc9ffd69944d=33b85867e30e1adc2ff2173039c199b81c10f52b=instructions:u >From a quick glance at your implementation, I

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: I tried to use `squash and merge` but the commit message using the wrong email address. Therefore, I have committed the changes using the git command. https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi closed https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From 5b750383cace7db24144d16ce8a9ca0864c37613 Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH] [Clang] Add two time-trace scope variables. A time trace scope

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From 8ff407fc56d9725cc630172c6536f1d565e095fe Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH] [Clang] Add two time-trace scope variables. A time trace scope

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -301,6 +301,10 @@ Improvements to Clang's diagnostics - Clang now always diagnoses when using non-standard layout types in ``offsetof`` . (`#64619: `_) +Improvements to Clang's time-trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -301,6 +301,10 @@ Improvements to Clang's diagnostics - Clang now always diagnoses when using non-standard layout types in ``offsetof`` . (`#64619: `_) +Improvements to Clang's time-trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From cc5cf9500cbdbb2fdd332c7de26c0516e49594bf Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/4] Add a new time trace scope variable named

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -301,6 +301,10 @@ Improvements to Clang's diagnostics - Clang now always diagnoses when using non-standard layout types in ``offsetof`` . (`#64619: `_) +Improvements to Clang's time-trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman commented: Your release note looks great, just a few formatting related nits with it. https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Hi @AaronBallman, Thanks for reviewing and approving the patch. I have added a release note in the commit https://github.com/llvm/llvm-project/pull/65268/commits/014ad430c465f40b02ebd511038a2bf1bdff217c. Since I haven't ever added a release note before, could you please

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From cc5cf9500cbdbb2fdd332c7de26c0516e49594bf Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/4] Add a new time trace scope variable named

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman approved this pull request. LGTM, thank you for this! Please add a release note letting users know about the improvement when you land the changes. https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Gentle ping ... https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From cc5cf9500cbdbb2fdd332c7de26c0516e49594bf Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/3] Add a new time trace scope variable named

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (MaggieYingYi) Changes When profiling code using `-ftime-trace` with the default `time-trace-granularity` value (500 microseconds), in some code there is a large empty timeline in the flame chart profiling view (using Chrome

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi updated https://github.com/llvm/llvm-project/pull/65268 >From cc5cf9500cbdbb2fdd332c7de26c0516e49594bf Mon Sep 17 00:00:00 2001 From: Ying Yi Date: Fri, 1 Sep 2023 15:30:44 +0100 Subject: [PATCH 1/2] Add a new time trace scope variable named

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman commented: Apologies on the delayed review! Thank you for working on this; we really could use better time trace output in Clang to start helping us get a better handle on improving compile time performance. https://github.com/llvm/llvm-project/pull/65268

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

@@ -1224,6 +1225,9 @@ Parser::DeclGroupPtrTy Parser::ParseDeclOrFunctionDefInternal( Parser::DeclGroupPtrTy Parser::ParseDeclarationOrFunctionDefinition( ParsedAttributes , ParsedAttributes , ParsingDeclSpec *DS, AccessSpecifier AS) { + // Add an enclosing time trace

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Gentle ping ... https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaskRay wrote: > This seems fine to me, but it's hard to understand if this is redundant with > some other "ParseFunction" scope from the tests. WDYT @MaskRay ? I share similar concern but I am not familiar with the parser... @AaronBallman https://github.com/llvm/llvm-project/pull/65268

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/rnk commented: This seems fine to me, but it's hard to understand if this is redundant with some other "ParseFunction" scope from the tests. WDYT @MaskRay ? https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

MaggieYingYi wrote: Gentle ping ... https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi review_requested https://github.com/llvm/llvm-project/pull/65268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [time-trace] Add a new time trace scope variable named "ParseDeclarationOrFunctionDefinition". (PR #65268)

https://github.com/MaggieYingYi created https://github.com/llvm/llvm-project/pull/65268: When profiling code using `-ftime-trace` with the default `time-trace-granularity` value (500 microseconds), in some code there is a large empty timeline in the flame chart profiling view (using Chrome