[llvm] [openmp] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

jplehr wrote: This was brought up and discussed in the weekly meeting. https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [llvm] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

ronlieb wrote: > performance degradation observed for this patch on trunk build : hpc2021 8 > mpi210's reference run 518.tealeaf 10.8% 534.hpgmg 7.3% both of these benchmarks which exhibited performance regressions, contain reductions. https://github.com/llvm/llvm-project/pull/70401

[openmp] [llvm] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

ronlieb wrote: @jdoerfert please respond to our comments about peformance degradation ? https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[mlir] [openmp] [llvm] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

dhruvachak wrote: With reference to the performance degradation, this patch introduces an additional allocation/data-submit/deallocation for every kernel (GenericKernelTy::getKernelLaunchEnvironment(), PluginInterface.cpp). Analysis shows that this overhead appears to be the primary reason

[mlir] [openmp] [llvm] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

ronlieb wrote: performance degradation observed for this patch on trunk build : hpc2021 8 mpi210's reference run 518.tealeaf 10.8% 534.hpgmg7.3% https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list

[openmp] [llvm] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

https://github.com/jdoerfert closed https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [llvm] [mlir] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

https://github.com/jdoerfert edited https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[openmp] [mlir] [llvm] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

https://github.com/jhuber6 approved this pull request. LG https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[llvm] [openmp] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

jhuber6 wrote: Small change that affects a lot of tests. LG once these are fixed: ``` MLIR :: Target/LLVMIR/omptarget-region-device-llvm.mlir MLIR :: Target/LLVMIR/omptarget-byref-bycopy-generation-device.mlir MLIR :: Target/LLVMIR/omptarget-declare-target-llvm-device.mlir ```

[llvm] [openmp] [clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

shiltian wrote: Tests in `mlir` have to be updated as well. https://github.com/llvm/llvm-project/pull/70401 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument (PR #70401)

llvmbot wrote: @llvm/pr-subscribers-flang-openmp Author: Johannes Doerfert (jdoerfert) Changes [OpenMP] Introduce the KernelLaunchEnvironment as implicit argument The KernelEnvironment is for compile time information about a kernel. It allows the compiler to feed