Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

2020-02-13 Thread Hans Wennborg via cfe-commits
Unless there's demand for it, I'd be inclined to pass on merging since it doesn't seem entirely trivial. On Wed, Feb 12, 2020 at 1:56 PM Richard Smith via cfe-commits wrote: > > It's a wrong-code bugfix, but we've had the bug since Clang 3.5, so it > doesn't seem urgent. > > Hans, what do you

Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

2020-02-12 Thread Richard Smith via cfe-commits
It's a wrong-code bugfix, but we've had the bug since Clang 3.5, so it doesn't seem urgent. Hans, what do you think? I don't think we've had any field reports of miscompiles (though someone did notice the ubsan false-positive). On Sat, 1 Feb 2020 at 05:04, Shoaib Meenai wrote: > Should this be

Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

2020-01-31 Thread Shoaib Meenai via cfe-commits
Should this be cherry-picked to 10.0? On 1/31/20, 7:09 PM, "cfe-commits on behalf of Richard Smith via cfe-commits" wrote: Author: Richard Smith Date: 2020-01-31T19:08:17-08:00 New Revision: 0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 URL:

[clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

2020-01-31 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2020-01-31T19:08:17-08:00 New Revision: 0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 URL: https://github.com/llvm/llvm-project/commit/0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 DIFF: https://github.com/llvm/llvm-project/commit/0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4.diff