Re: [clang] 3ced239 - Refactor CompareReferenceRelationship and its callers in preparation for

2019-12-28 Thread Kim Gräsman via cfe-commits
Yes, it is this change that broke us. I still don't fully understand what the change was, but it appears to mess things up for IWYU for operator== with templates and const, somehow. Could you expand on what changed here and how the AST might be affected? Thanks, - Kim On Sat, Dec 28, 2019 at

Re: [clang] 3ced239 - Refactor CompareReferenceRelationship and its callers in preparation for

2019-12-28 Thread Kim Gräsman via cfe-commits
Hi Richard, I see the commit message mentions type sugar here; does this change affect the AST at all? We're seeing test failures in IWYU based on recent Clang, and I'm suspecting this commit (it takes me a while to bisect because of Clang build times on my laptop). Thanks, - Kim On Wed, Dec

[clang] 3ced239 - Refactor CompareReferenceRelationship and its callers in preparation for

2019-12-18 Thread Richard Smith via cfe-commits
Author: Richard Smith Date: 2019-12-18T14:05:57-08:00 New Revision: 3ced23976aa8a86a17017c87821c873b4ca80bc2 URL: https://github.com/llvm/llvm-project/commit/3ced23976aa8a86a17017c87821c873b4ca80bc2 DIFF: https://github.com/llvm/llvm-project/commit/3ced23976aa8a86a17017c87821c873b4ca80bc2.diff