Author: Zahira Ammarguellat Date: 2022-02-17T10:59:54-08:00 New Revision: 4dfa68e483137cc13eb9027c0dd834ede19f2fd4
URL: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4 DIFF: https://github.com/llvm/llvm-project/commit/4dfa68e483137cc13eb9027c0dd834ede19f2fd4.diff LOG: [NFC] Fix debug-info-hotpatch.cpp failure due to downstream regex issue. In our downstream, we discovered that the that the .* wildcard in debug-info-hotpatch.cpp (added https://reviews.llvm.org/D116511) ended up matching the entire line on our Windows configurations, causing the -function-padmin check to already be consumed. After digging into it we weren't able to find any sort of reason why the platform would matter here, however we suspect there must be some difference in the regex matcher between systems. This NFC patch replaces the regex with a more conservative regex that prevents this from happening by replacing the . match with an 'everything but double-quote match, [^"]. https://reviews.llvm.org/D120066 Added: Modified: clang/test/CodeGenCXX/debug-info-hotpatch.cpp Removed: ################################################################################ diff --git a/clang/test/CodeGenCXX/debug-info-hotpatch.cpp b/clang/test/CodeGenCXX/debug-info-hotpatch.cpp index fde1a6ad085ea..e005c9c5ee489 100644 --- a/clang/test/CodeGenCXX/debug-info-hotpatch.cpp +++ b/clang/test/CodeGenCXX/debug-info-hotpatch.cpp @@ -12,7 +12,7 @@ // RUN: %clang_cl --target=x86_64-windows-msvc /hotpatch -### -- %s 2>&1 \ // RUN: | FileCheck %s --check-prefix=FUNCTIONPADMIN // FUNCTIONPADMIN: clang{{.*}} -// FUNCTIONPADMIN: {{link.*"}} +// FUNCTIONPADMIN: {{link[^"]*"}} // FUNCTIONPADMIN: -functionpadmin int main() { _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits