Author: Youngsuk Kim Date: 2023-11-04T19:59:39-05:00 New Revision: 730d313041f73760aacc3fa3b12b5b5b0c92a12c
URL: https://github.com/llvm/llvm-project/commit/730d313041f73760aacc3fa3b12b5b5b0c92a12c DIFF: https://github.com/llvm/llvm-project/commit/730d313041f73760aacc3fa3b12b5b5b0c92a12c.diff LOG: [CGObjC] Remove no-op ptr-to-ptr bitcasts (NFC) Opaque ptr cleanup effort (NFC) Added: Modified: clang/lib/CodeGen/CGObjC.cpp Removed: ################################################################################ diff --git a/clang/lib/CodeGen/CGObjC.cpp b/clang/lib/CodeGen/CGObjC.cpp index 5c967f97018f800..fff89c8939a55a4 100644 --- a/clang/lib/CodeGen/CGObjC.cpp +++ b/clang/lib/CodeGen/CGObjC.cpp @@ -52,8 +52,7 @@ llvm::Value *CodeGenFunction::EmitObjCStringLiteral(const ObjCStringLiteral *E) { llvm::Constant *C = CGM.getObjCRuntime().GenerateConstantString(E->getString()).getPointer(); - // FIXME: This bitcast should just be made an invariant on the Runtime. - return llvm::ConstantExpr::getBitCast(C, ConvertType(E->getType())); + return C; } /// EmitObjCBoxedExpr - This routine generates code to call @@ -3710,7 +3709,7 @@ CodeGenFunction::GenerateObjCAtomicSetterCopyHelperFunction( CharUnits Alignment = C.getTypeAlignInChars(Ty); llvm::Constant *Fn = getNonTrivialCStructMoveAssignmentOperator( CGM, Alignment, Alignment, Ty.isVolatileQualified(), Ty); - return llvm::ConstantExpr::getBitCast(Fn, VoidPtrTy); + return Fn; } if (!getLangOpts().CPlusPlus || @@ -3790,7 +3789,7 @@ CodeGenFunction::GenerateObjCAtomicSetterCopyHelperFunction( EmitStmt(TheCall); FinishFunction(); - HelperFn = llvm::ConstantExpr::getBitCast(Fn, VoidPtrTy); + HelperFn = Fn; CGM.setAtomicSetterHelperFnMap(Ty, HelperFn); return HelperFn; } @@ -3808,7 +3807,7 @@ llvm::Constant *CodeGenFunction::GenerateObjCAtomicGetterCopyHelperFunction( CharUnits Alignment = C.getTypeAlignInChars(Ty); llvm::Constant *Fn = getNonTrivialCStructCopyConstructor( CGM, Alignment, Alignment, Ty.isVolatileQualified(), Ty); - return llvm::ConstantExpr::getBitCast(Fn, VoidPtrTy); + return Fn; } if (!getLangOpts().CPlusPlus || @@ -3909,7 +3908,7 @@ llvm::Constant *CodeGenFunction::GenerateObjCAtomicGetterCopyHelperFunction( AggValueSlot::IsNotAliased, AggValueSlot::DoesNotOverlap)); FinishFunction(); - HelperFn = llvm::ConstantExpr::getBitCast(Fn, VoidPtrTy); + HelperFn = Fn; CGM.setAtomicGetterHelperFnMap(Ty, HelperFn); return HelperFn; } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
