https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
I guess buildkite/github-pull-requests is stuck
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
@jfbastien @fhahn @efriedma-quic I'd like to merge if no other feedback
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi
https://github.com/vitalybuka approved this pull request.
LGTM, but please wait others feedback
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-
vitalybuka wrote:
As we discussed offline, it would nice to handle cases like this
```
struct Foo {
int x; // we should try to make sure X is initialized.
char buff[1024]; // this one is fine to skip
};
void main() {
Foo foo;
}
```
But seems moving size check deeper does not help. I
@@ -0,0 +1,60 @@
+// Pattern related max size tests: 1, 1024, 4096
+// RUN: %clang_cc1 -triple x86_64-unknown-unknown
-ftrivial-auto-var-init=pattern -ftrivial-auto-var-init-max-size=1 %s
-emit-llvm -o - | FileCheck -check-prefix=PATTERN-COMMON
-check-prefix=PATTERN-MAX-1 %s
+/
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1205,10 +1205,19 @@ static void emitStoresForConstant(CodeGenModule &CGM,
const VarDecl &D,
}
auto *SizeVal = llvm::ConstantInt::get(CGM.IntPtrTy, ConstantSize);
+ auto trivialAutoVarInitMaxSize =
vitalybuka wrote:
would it be simpler
```
if (IsA
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def err_drv_trivial_auto_var_init_siz
@@ -1759,20 +1759,29 @@ void
CodeGenFunction::emitZeroOrPatternForAutoVarInit(QualType type,
const VarDecl &D,
Address Loc) {
auto trivialAutoVarInit = getContext().ge
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def err_drv_trivial_auto_var_init_siz
@@ -656,6 +656,13 @@ def
err_drv_trivial_auto_var_init_stop_after_missing_dependency : Error<
def err_drv_trivial_auto_var_init_stop_after_invalid_value : Error<
"'-ftrivial-auto-var-init-stop-after=*' only accepts positive integers">;
+def err_drv_trivial_auto_var_init_siz
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haopliu updated
https://github.com/llvm/llvm-project/pull/74777
>From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001
From: Haopeng Liu
Date: Thu, 7 Dec 2023 21:25:33 +
Subject: [PATCH 1/5] Add size filter for stack auto init
---
.../include/clang/Basi
https://github.com/haopliu updated
https://github.com/llvm/llvm-project/pull/74777
>From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001
From: Haopeng Liu
Date: Thu, 7 Dec 2023 21:25:33 +
Subject: [PATCH 1/4] Add size filter for stack auto init
---
.../include/clang/Basi
https://github.com/haopliu updated
https://github.com/llvm/llvm-project/pull/74777
>From bb5acad16c6a627d73a5af96e3dd4eba2ebe1a5d Mon Sep 17 00:00:00 2001
From: Haopeng Liu
Date: Thu, 7 Dec 2023 21:25:33 +
Subject: [PATCH 1/3] Add size filter for stack auto init
---
.../include/clang/Basi
https://github.com/haopliu edited
https://github.com/llvm/llvm-project/pull/74777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c6805ea44af3bfd57e6b46f2d65ec6b0d0d6c64a
00af66353d938c6ce59dada49c8bededb06ac4fc --
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (haopliu)
Changes
Add a clang flag, "-ftrivial-auto-var-init-size-bound=" so that clang skips
auto-init a variable if its size exceeds the flag setting. Note that this
skipping doesn't apply to runtime-sized variables like VL
https://github.com/haopliu created
https://github.com/llvm/llvm-project/pull/74777
Add a clang flag, "-ftrivial-auto-var-init-size-bound=" so that clang skips
auto-init a variable if its size exceeds the flag setting. Note that this
skipping doesn't apply to runtime-sized variables like VLA.
27 matches
Mail list logo