[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -85,3 +85,38 @@ int main() { } + +namespace deduceTemplatedConstructor{ HoBoIs wrote: Done https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

Botond =?utf-8?q?Istv=C3=A1n_Hprv=C3=A1th?= Message-ID: In-Reply-To: https://github.com/whisperity requested changes to this pull request. https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/5] Choose the correct deduction guide If there are two guides, one of

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -85,3 +85,13 @@ int main() { } + +namespace deduceTemplatedConstructor{ shafik wrote: I apologize for asking you to do additional work here but can you add the rest of the examples from [over.match.best.general

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/shafik approved this pull request. Thank you for the follow-up work. LGTM https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/4] Choose the correct deduction guide If there are two guides, one of

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/3] Choose the correct deduction guide If there are two guides, one of

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/erichkeane approved this pull request. Just need a period after the note, otherwise LGTM! https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -390,6 +390,11 @@ Bug Fixes to C++ Support we now produce a diagnostic. Fixes: (`#65522 `_) +- Fixed a bug where clang incorrectly considered implicitly generated deduction + guides from a non-templated constructor

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -390,6 +390,10 @@ Bug Fixes to C++ Support we now produce a diagnostic. Fixes: (`#65522 `_) +- Fixed a bug where clang couldn't choose the correct deduction guide from + two implicitly generated deduction guides. One

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH 1/2] Choose the correct deduction guide If there are two guides, one of

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

erichkeane wrote: > The paper where this came from is: https://wg21.link/P0620R0. most of this > paper was already implemented. Where is the paper tracking doc I need to > update? https://clang.llvm.org/cxx_status.html claims this paper is > implemented. Sorry if the following questions are

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH] Choose the correct deduction guide If there are two guides, one of them

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

HoBoIs wrote: Deduction guides were added in C++17, and This paper is also in C++17, so I don't think we need to check for versions in the code (I don't create any deduction guides I just use them so before C++17 my code is never used). https://github.com/llvm/llvm-project/pull/66487

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

HoBoIs wrote: The paper where this came from is: https://wg21.link/P0620R0. most of this paper was already implemented. Where is the paper tracking doc I need to update? https://clang.llvm.org/cxx_status.html claims this paper is implemented. Sorry if the following questions are trivial, I'm

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

shafik wrote: I added a comment in the issue her: https://github.com/llvm/llvm-project/issues/67959#issuecomment-1743564143 Please make sure to add references to the standard in appropriate places in this PR. https://github.com/llvm/llvm-project/pull/66487

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/erichkeane commented: This seems right to me, however we need to do 2 things: 1- This needs a release note. 2- We need to track down when this changed in the standard, and why. If it was a DR, we need to do make sure we update that we've implemented that DR. If it was a

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -2129,7 +2129,7 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( Function = CXXDeductionGuideDecl::Create( SemaRef.Context, DC, D->getInnerLocStart(), InstantiatedExplicitSpecifier, NameInfo, T, TInfo, -D->getSourceRange().getEnd(),

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

cor3ntin wrote: @erichkeane https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

HoBoIs wrote: @zygoloid @yuanfang-chen @faisalv @OleStrohm Could you review my commit and/or suggest more appropriate reviewers? Thanks in advance! https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs ready_for_review https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs edited https://github.com/llvm/llvm-project/pull/66487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

@@ -2129,7 +2129,7 @@ Decl *TemplateDeclInstantiator::VisitFunctionDecl( Function = CXXDeductionGuideDecl::Create( SemaRef.Context, DC, D->getInnerLocStart(), InstantiatedExplicitSpecifier, NameInfo, T, TInfo, -D->getSourceRange().getEnd(),

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs updated https://github.com/llvm/llvm-project/pull/66487 >From 258462cc65403af147bb47cbeb95210df8e18cd3 Mon Sep 17 00:00:00 2001 From: hobois Date: Fri, 15 Sep 2023 09:28:21 +0200 Subject: [PATCH] Choose the correct deduction guide If there are two guides, one of them

[clang] Bugfix for chosing the correct deduction guide (PR #66487)

https://github.com/HoBoIs created https://github.com/llvm/llvm-project/pull/66487 If there is 2 guides one of them generated from a non-templated constructor and one of them from a templated constructor the standard gives priority to the first. Clang detected ambiguity before, now the correct