amykhuang wrote:
nevermind, that example is working as intended
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
amykhuang wrote:
here's a reduced example of what we ran into in Chrome. I guess the attribute
is being applied to a function that's passed to `f()`, and the warning points
to the call in the definition of `f`.
```
#define a(b) __attribute__((__availability__(android, introduced = b)))
llvm-beanz wrote:
@nico, am I correct to assume those aren't false positives, just a bunch of
places that didn't warn before?
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
nico wrote:
Any chance to put these behind a subgroup? This now fires in a bunch of places
where it didn't before.
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/hekota closed https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hekota wrote:
Thanks Chris!
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz approved this pull request.
We've waited a week on this PR to see if anyone from Apple will chime in. On
previous PRs we waited weeks and got no response. We've reached out on Discord
too.
This PR looks sane to me and it seems to have adequate testing. I think we
@@ -177,16 +177,19 @@ void justAtAvailable(void) {
#ifdef OBJCPP
-int f(char) AVAILABLE_10_12;
+int f(char) AVAILABLE_10_12; // #f_char_def
int f(int);
template int use_f() {
- // FIXME: We should warn here!
- return f(T());
hekota wrote:
Thanks for
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/91699
>From 6220a5f61f92c3161772fd7c2be9d387169f8e03 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Thu, 9 May 2024 22:14:05 -0700
Subject: [PATCH 1/2] Enable unguarded availability diagnostic on instantiated
@@ -177,16 +177,19 @@ void justAtAvailable(void) {
#ifdef OBJCPP
-int f(char) AVAILABLE_10_12;
+int f(char) AVAILABLE_10_12; // #f_char_def
int f(int);
template int use_f() {
- // FIXME: We should warn here!
- return f(T());
epilk wrote:
Could you
@@ -177,16 +177,19 @@ void justAtAvailable(void) {
#ifdef OBJCPP
-int f(char) AVAILABLE_10_12;
+int f(char) AVAILABLE_10_12; // #f_char_def
int f(int);
template int use_f() {
- // FIXME: We should warn here!
- return f(T());
+ // expected-warning@#f_call {{'f' is
https://github.com/coopp approved this pull request.
Looks fine to me. I assume this doesn't impact other test passes right? Now
there is work being done when before it was doing an early out for template
instantiations.
https://github.com/llvm/llvm-project/pull/91699
https://github.com/coopp edited https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -177,16 +177,19 @@ void justAtAvailable(void) {
#ifdef OBJCPP
-int f(char) AVAILABLE_10_12;
+int f(char) AVAILABLE_10_12; // #f_char_def
int f(int);
template int use_f() {
- // FIXME: We should warn here!
- return f(T());
+ // expected-warning@#f_call {{'f' is
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Helena Kotas (hekota)
Changes
Availability diagnostic in instantiated template functions was intentionally
skipped in the original
[commit](https://github.com/llvm/llvm-project/commit/5cd57177a51abc7b0bfe18f70566572dbccab9a0)
years ago
https://github.com/hekota ready_for_review
https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/91699
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota created
https://github.com/llvm/llvm-project/pull/91699
None
>From 6220a5f61f92c3161772fd7c2be9d387169f8e03 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Thu, 9 May 2024 22:14:05 -0700
Subject: [PATCH] Enable unguarded availability diagnostic on instantiated
18 matches
Mail list logo
