[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

rjmccall wrote: Great, thanks! @Midar, if you can fix this code up so that these strings are created in one place (and test the new output, since this is not NFC), I'd be happy to sign off. https://github.com/llvm/llvm-project/pull/88713 ___

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

davidchisnall wrote: Yup, it’s just an optimisation. The runtime does a slightly more complex deduplication pass during loading, this just does a best effort merge so that we don’t end up with hundreds of copies of common selectors as we did with the GCC ABI. If we don’t do it, it isn’t an

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

Midar wrote: These symbols are just used to deduplicate strings: That's why they're hidden and in COMDAT. So I don't think it'll break or fix the ABI ;). https://github.com/llvm/llvm-project/pull/88713 ___ cfe-commits mailing list

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/88713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

https://github.com/rjmccall commented: At first, I was worried that this was an ABI break. Then I noticed the internal inconsistency within this single file, and so I became worried that it was an ABI *fix*. But then I noticed that the normal selector-emission code actually makes these

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

Midar wrote: Maybe @rjmccall would be a good reviewer? https://github.com/llvm/llvm-project/pull/88713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

https://github.com/Midar updated https://github.com/llvm/llvm-project/pull/88713 >From 8dc7333c0e9c757bba91ebfbe57280ad0635afa9 Mon Sep 17 00:00:00 2001 From: Jonathan Schleifer Date: Mon, 15 Apr 2024 13:36:05 +0200 Subject: [PATCH] Fix objc_sel_{name,types} missing an underscore The other

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

llvmbot wrote: @llvm/pr-subscribers-clang Author: Jonathan Schleifer (Midar) Changes The other places all use the underscore. This is just a quick drive-by commit, LMK if more is needed. --- Full diff: https://github.com/llvm/llvm-project/pull/88713.diff 1 Files Affected: -

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] Fix objc_sel_{name,types} missing an underscore (PR #88713)

https://github.com/Midar created https://github.com/llvm/llvm-project/pull/88713 The other places all use the underscore. This is just a quick drive-by commit, LMK if more is needed. >From e39e2fc218c588d66937211f98a25eb2acf00a6b Mon Sep 17 00:00:00 2001 From: Jonathan Schleifer Date: Mon, 15