[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

github-actions[bot] wrote: @higher-performance Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

higher-performance wrote: Looks like the build passed as well :) https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

higher-performance wrote: Added a release note as well; feel free to edit it if needed (or let me know if I should change anything)! https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/87824 >From 78f18445804fdb1cdf7810f56d3ae3c6e55f8da7 Mon Sep 17 00:00:00 2001 From: higher-performance <113926381+higher-performa...@users.noreply.github.com> Date: Fri, 5 Apr 2024 15:36:05 -0400 Subject:

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

@@ -61,7 +61,28 @@ class ParentMapContext::ParentMap { template friend struct ::MatchParents; /// Contains parents of a node. - using ParentVector = llvm::SmallVector; + class ParentVector { + public: +ParentVector() = default; +explicit ParentVector(size_t n,

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

@@ -61,7 +61,28 @@ class ParentMapContext::ParentMap { template friend struct ::MatchParents; /// Contains parents of a node. - using ParentVector = llvm::SmallVector; + class ParentVector { + public: +ParentVector() = default; +explicit ParentVector(size_t n,

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/AaronBallman commented: Thank you for this, what a great speed-up! Generally LGTM, though I think you should add a release note to clang/docs/ReleaseNotes.rst so users know about the significant performance improvement. https://github.com/llvm/llvm-project/pull/87824

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

higher-performance wrote: @shafik @AaronBallman if you could kindly review this I'd appreciate it! https://github.com/llvm/llvm-project/pull/87824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

llvmbot wrote: @llvm/pr-subscribers-clang Author: None (higher-performance) Changes Avoids the need to linearly re-scan all seen parent nodes to check for duplicates, which previously caused a slowdown for ancestry checks in Clang AST matchers. Fixes: #86881 --- Full diff:

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you,

[clang] Fix quadratic slowdown in AST matcher parent map generation (PR #87824)

https://github.com/higher-performance created https://github.com/llvm/llvm-project/pull/87824 Avoids the need to linearly re-scan all seen parent nodes to check for duplicates, which previously caused a slowdown for ancestry checks in Clang AST matchers. Fixes: #86881 >From