[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread via cfe-commits
https://github.com/serge-sans-paille closed https://github.com/llvm/llvm-project/pull/73491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/73491 >From c66e50ee0c804eadd8cb09650f41cc31a76e8bdd Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 27 Nov 2023 10:17:32 +0100 Subject: [PATCH 1/2] Improve clang-format-diff help output It is

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread Owen Pan via cfe-commits
https://github.com/owenca approved this pull request. https://github.com/llvm/llvm-project/pull/73491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread via cfe-commits
serge-sans-paille wrote: @owenca bug opened as #73635 and commit message updated to link to it. https://github.com/llvm/llvm-project/pull/73491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/73491 >From c66e50ee0c804eadd8cb09650f41cc31a76e8bdd Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 27 Nov 2023 10:17:32 +0100 Subject: [PATCH 1/2] Improve clang-format-diff help output It is

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread Owen Pan via cfe-commits
owenca wrote: Please open a github issue to show us what you are trying to accomplish and reference the issue number here. https://github.com/llvm/llvm-project/pull/73491 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-28 Thread via cfe-commits
serge-sans-paille wrote: > See below. Seems it's already working as expected without this patch. > > ``` > $ clang-format -version > clang-format version 17.0.5 > $ clang-format-diff.py foo > usage: clang-format-diff.py [-h] [-i] [-p NUM] [-regex PATTERN] [-iregex > PATTERN] >

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread Owen Pan via cfe-commits
owenca wrote: See below. Seems it's already working as expected without this patch. ``` $ clang-format -version clang-format version 17.0.5 $ clang-format-diff.py foo usage: clang-format-diff.py [-h] [-i] [-p NUM] [-regex PATTERN] [-iregex PATTERN] [-sort-includes]

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
https://github.com/serge-sans-paille updated https://github.com/llvm/llvm-project/pull/73491 >From 788d03126f95ffc8d3b9701fdba73bb931e25cfc Mon Sep 17 00:00:00 2001 From: serge-sans-paille Date: Mon, 27 Nov 2023 10:17:32 +0100 Subject: [PATCH 1/2] Improve clang-format-diff help output It is

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 772f296214e10323ca16921c02b1852307b7d51b..788d03126f95ffc8d3b9701fdba73bb931e25cfc

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: None (serge-sans-paille) Changes It is quite common to symlink clang-format-diff.py to clang-format-diff, and in that case the help output still refers to the .py version. Compute it instead to work in both setup. --- Full diff:

[clang] Improve clang-format-diff help output (PR #73491)

2023-11-27 Thread via cfe-commits
https://github.com/serge-sans-paille created https://github.com/llvm/llvm-project/pull/73491 It is quite common to symlink clang-format-diff.py to clang-format-diff, and in that case the help output still refers to the .py version. Compute it instead to work in both setup. >From