[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-24 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > @yxsamliu I've just raised #70055 which fixes an issue with the new test > here. Perhaps it might also allow you to remove the exclusion for > `system-darwin`? Yes it should allow it to remove exclusion of system-darwin. Thanks https://github.com/llvm/llvm-project/pull/68921

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-24 Thread Simon Tatham via cfe-commits
statham-arm wrote: @yxsamliu I've just raised https://github.com/llvm/llvm-project/pull/70055 which fixes an issue with the new test here. Perhaps it might also allow you to remove the exclusion for `system-darwin`? https://github.com/llvm/llvm-project/pull/68921 __

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-23 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: [AMD Official Use Only - General] Sorry I missed this failure. Will fix it now. Sam From: Rainer Orth ***@***.***> Sent: Monday, October 23, 2023 5:45 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [llvm/llvm-pro

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-23 Thread Rainer Orth via cfe-commits
rorth wrote: This patch also broke the [Solaris/amd64 buildbot](https://lab.llvm.org/staging/#/builders/8/builds/484). I suspect this happens because that one is configured with `-DLLVM_TARGETS_TO_BUILD=X86`, thus lacking cuda support. In fact, when manually building with support for all ta

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: [AMD Official Use Only - General] Fixed by 9d10fbbb299eae4a63f1028274e2ffe92bf8e75a From: Nico Weber ***@***.***> Sent: Thursday, October 19, 2023 8:03 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [llvm/llvm-proj

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: [AMD Official Use Only - General] Will fix it now. Thanks. Sam From: Nico Weber ***@***.***> Sent: Thursday, October 19, 2023 8:03 PM To: llvm/llvm-project ***@***.***> Cc: Liu, Yaxun (Sam) ***@***.***>; State change ***@***.***> Subject: Re: [llvm/llvm-project] Let clang-cl su

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Nico Weber via cfe-commits
nico wrote: Hello, it looks like this breaks check-clang on mac: http://45.33.8.238/macm1/71368/step_7.txt Please take a look and revert for now if it takes a while to fix. https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Reid Kleckner via cfe-commits
https://github.com/rnk approved this pull request. Yep, we are fairly liberal about adding new clang options to the clang-cl mode, especially if they are in the feature `-f` flag namespace, which we believe will not conflict with MSVC flags. https://github.com/llvm/llvm-project/pull/68921

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-19 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: ping. we tested it on Windows and it is able to compile both C++ and HIP without issues. https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-13 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: The main objective is to make porting cmake files easier. Without it, you have to use clang-cl.exe to compile C++ and clang.exe to compile HIP since the options are not compatible. Now you can use clang-cl.exe to compile both, which accepts both MSVC options and clang options.

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread Artem Belevich via cfe-commits
Artem-B wrote: @rnk -- would that be acceptable for clang-cl on windows? https://github.com/llvm/llvm-project/pull/68921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Yaxun (Sam) Liu (yxsamliu) Changes clang-cl is a driver mode that accepts options of MSVC cl.exe as a drop-in replacement for cl.exe. Currently clang-cl accepts mixed clang style options and cl style options. To let clang-cl accept a clan

[clang] Let clang-cl support CUDA/HIP (PR #68921)

2023-10-12 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu created https://github.com/llvm/llvm-project/pull/68921 clang-cl is a driver mode that accepts options of MSVC cl.exe as a drop-in replacement for cl.exe. Currently clang-cl accepts mixed clang style options and cl style options. To let clang-cl accept a clang-style