Sirraide wrote:
See also: #92439
https://github.com/llvm/llvm-project/pull/92283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Caslyn wrote:
Hi @sdkrystian & @erichkeane - my apologies!
Yes, indeed this code calls its own increment operator and it should be
`++*this` - I failed to see that. Thanks for the feedback here and helping us
fix this bug in our code.
https://github.com/llvm/llvm-project/pull/92283
erichkeane wrote:
> Hi @sdkrystian - this appears to break in a circumstance where a custom
> iterator class defines the postfix operator:
>
> ```
> FAILED: host_x64/obj/src/lib/zbitl/tests/zbitl-unittests.mem-config-test.cc.o
> ../../prebuilt/third_party/clang/custom/bin/clang++ -MD -MF
>
sdkrystian wrote:
@Caslyn [[expr.prim.this] p3](http://eel.is/c++draft/expr.prim.this#3) states:
> [...] the expression this is a prvalue of type “pointer to _cv-qualifier-seq_
> `X`” wherever `X` is the current class [...]
And [[over.match.oper] p1](http://eel.is/c++draft/over.match.oper#1)
Caslyn wrote:
Hi @sdkrystian - this appears to break in a circumstance where a custom
iterator class defines the postfix operator:
```
FAILED: host_x64/obj/src/lib/zbitl/tests/zbitl-unittests.mem-config-test.cc.o
../../prebuilt/third_party/clang/custom/bin/clang++ -MD -MF
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/92283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
https://github.com/llvm/llvm-project/pull/92283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
All the new changes are in 5ce0e969f3f94e9694545fe71b14fd8eb086f33e
https://github.com/llvm/llvm-project/pull/92283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
Can you point out the 'diff' inline what the change from the previous commit is?
https://github.com/llvm/llvm-project/pull/92283
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
This patch reapplies #90500, addressing a bug which caused binary
operators with dependent operands to be incorrectly rebuilt by `TreeTransform`.
---
Patch is 46.60 KiB, truncated to 20.00 KiB
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/92283
This patch reapplies #90500, addressing a bug which caused binary operators
with dependent operands to be incorrectly rebuilt by `TreeTransform`.
>From 365d97508883eb5a4f9b898f8277d16e1f6d3862 Mon Sep 17
11 matches
Mail list logo
