sdkrystian wrote:
The expression type need to be set to `ASTContext::DependentTy` (currently,
it's set to `ASTContext::OverloadTy`) if we find a member of a base class (as
it is for direct members). Should be an easy fix, so I'm thinking of not
reverting and just opening a PR that will
sdkrystian wrote:
@rupprecht looks like the issue is with non-static members in base classes:
```cpp
struct B
{
int z;
void h(int);
};
template
struct A : B
{
int y;
void g(int);
template
void f(U);
template<>
void f(int x)
{
x;
y;
rupprecht wrote:
Still seeing a few more failures, although the original repro is now working.
```c++
struct Base {
int BaseFunc(int x) { return 0; }
int val;
};
template
struct Foo : Base {
template
int bar(X x) {
return BaseFunc(val); // OK
}
template <>
https://github.com/sdkrystian closed
https://github.com/llvm/llvm-project/pull/88311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/6] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/5] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/4] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/erichkeane approved this pull request.
Can you add the example that caused the revert to the tests?
Else, LGTM.
https://github.com/llvm/llvm-project/pull/88311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
sdkrystian wrote:
@erichkeane Apologies, I should have structured the commits differently so it's
clear what the new changes are...
I added an `IsAddressOfOperand` parameter to
`TreeTransform::TransformUnresolvedLookupExpr` and changed the conditions under
which
https://github.com/erichkeane commented:
Can you point out the 'diff' from the last patch for me?
https://github.com/llvm/llvm-project/pull/88311
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH 1/3] Reapply "[Clang][Sema] Fix crash when 'this' is used
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Reapplies #87541 and addresses the bug which caused expressions naming
overload sets to be incorrectly rebuilt.
---
Full diff: https://github.com/llvm/llvm-project/pull/88311.diff
8 Files
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88311
>From eb389e142b18d1a14d23d9fadea3c503331c2f73 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 9 Apr 2024 08:31:52 -0400
Subject: [PATCH] Reapply "[Clang][Sema] Fix crash when 'this' is used in
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88311
Reapplies #87541 and addresses the bug which caused expressions naming overload
sets to be incorrectly rebuilt.
>From f6d703151ec06cec140c4d425dc2bbd8b7ac4f93 Mon Sep 17 00:00:00 2001
From: Krystian
16 matches
Mail list logo
