[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle closed https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -1061,11 +1061,13 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise:

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From f3b0c9708bbf6fb0962fb82b605a7fc0b52d4a5b Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -2278,7 +2303,7 @@ void ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContext ) { PostOrderCFGView::CFGBlockSet VisitedBlocks(CFGraph); CFGBlockInfo = BlockInfo[CFGraph->getEntry().getBlockID()]; - CFGBlockInfo= BlockInfo[CFGraph->getExit().getBlockID()]; +

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -1061,11 +1061,13 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise:

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -2278,7 +2303,7 @@ void ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContext ) { PostOrderCFGView::CFGBlockSet VisitedBlocks(CFGraph); CFGBlockInfo = BlockInfo[CFGraph->getEntry().getBlockID()]; - CFGBlockInfo= BlockInfo[CFGraph->getExit().getBlockID()]; +

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/aaronpuchert approved this pull request. Assuming that this is otherwise identical to the Phab review. I would suggest to add some release notes (in a separate change). https://github.com/llvm/llvm-project/pull/68572 ___

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/aaronpuchert edited https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/aeubanks approved this pull request. the flag changes lgtm and the remaining code was already reviews, so push it! https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle edited https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From db868042066e8b985d20c1b728729ba7102aaefa Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -1061,18 +1061,20 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise:

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From 2d90dc0547f90c3a217428b2d3b8d2253ae80973 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle updated https://github.com/llvm/llvm-project/pull/68572 >From 11f5286f426d082f7fbcb578c0c6cabcd3660453 Mon Sep 17 00:00:00 2001 From: Clement Courbet Date: Mon, 9 Oct 2023 10:20:12 +0200 Subject: [PATCH]

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

@@ -1061,18 +1061,20 @@ def Most : DiagGroup<"most", [ ]>; // Thread Safety warnings -def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">; -def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">; -def ThreadSafetyPrecise:

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

legrosbuffle wrote: @aeubanks FYI https://github.com/llvm/llvm-project/pull/68572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

llvmbot wrote: @llvm/pr-subscribers-clang Changes …… (#68394)" The new warnings are now under a separate flag `-Wthread-safety-reference-return`. The plan is: - Start with a period where people can opt into the new warnings with `-Wthread-safety-reference-return` or

[clang] Reapply "[clang analysis][thread-safety] Handle return-by-reference..… (PR #68572)

https://github.com/legrosbuffle created https://github.com/llvm/llvm-project/pull/68572 …… (#68394)" The new warnings are now under a separate flag `-Wthread-safety-reference-return`. The plan is: - Start with a period where people can opt into the new warnings with