jyu2-git wrote:
Hi @vitalybuka, do you think, this patch is ready to check-in? Thanks.
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jyu2-git wrote:
Hi @vitalybuka, could you please try to see if this change fix the problem?
Thanks.
I also put same fix in https://github.com/llvm/llvm-project/pull/91141. But
both test run fails, which should not cause by my change.
Thanks again.
Jennifer
https://github.com/llvm/llvm-proje
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a8fbe500fe2ecdbd3c09ed06788092937819411f
ebb6ac3dc1cc5f4e604ec3c7e68821432856920f --
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a8fbe500fe2ecdbd3c09ed06788092937819411f
ae7c7fd37eed7ff76ffddd778685450f084f3162 --
https://github.com/jyu2-git updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH 1/4] Revert "Revert "[OpenMP][TR12] change property of
map-type modifi
https://github.com/jyu2-git updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH 1/3] Revert "Revert "[OpenMP][TR12] change property of
map-type modifi
https://github.com/jyu2-git updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH 1/2] Revert "Revert "[OpenMP][TR12] change property of
map-type modifi
jyu2-git wrote:
I don't really understand the problem. So you mean
static_cast having problem?
We have two function like this the other one is isMapModifier. I just wonder
why we don't have problem before.
https://github.com/llvm/llvm-project/pull/90935
___
vitalybuka wrote:
Yes, its there
but it's too late
we can't cast to enum invalid values
it should be like:
```
unsigned MapType = getOpenMPSimpleClauseType(
OMPC_map, PP.getSpelling(Tok), P.getLangOpts());
if (MapType == OMPC_MAP_to || MapType == OMPC_MAP_from ||
MapType ==
jyu2-git wrote:
Hi @vitalybuka, could you please check what in isMapType
clang/lib/Parse/ParseOpenMP.cpp :
Should look like following:
static OpenMPMapClauseKind isMapType(Parser &P) {
Token Tok = P.getCurToken();
// The map-type token can be either an identifier or the C++ delete keyword.
jyu2-git wrote:
> It fails with
>
> ```
> diff --git a/clang/lib/Parse/ParseOpenMP.cpp b/clang/lib/Parse/ParseOpenMP.cpp
> index 53d89ce2fa3e..1a4442f38f6d 100644
> --- a/clang/lib/Parse/ParseOpenMP.cpp
> +++ b/clang/lib/Parse/ParseOpenMP.cpp
> @@ -4326,6 +4326,7 @@ static OpenMPMapClauseKind is
vitalybuka wrote:
```
diff --git a/clang/lib/Parse/ParseOpenMP.cpp b/clang/lib/Parse/ParseOpenMP.cpp
index 53d89ce2fa3e..1a4442f38f6d 100644
--- a/clang/lib/Parse/ParseOpenMP.cpp
+++ b/clang/lib/Parse/ParseOpenMP.cpp
@@ -4326,6 +4326,7 @@ static OpenMPMapClauseKind isMapType(Parser &P) {
OpenM
vitalybuka wrote:
> > 7c28408
>
> good point, maybe not, I scheduled it as with, without rebase. Let's try
> again.
Still fails after rebase https://lab.llvm.org/buildbot/#/builders/5/builds/43115
https://github.com/llvm/llvm-project/pull/90935
___
jyu2-git wrote:
> > 7c28408
>
> good point, maybe not, I scheduled it as with, without rebase. Let's try
> again.
Greate! Thank you so much!!
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/vitalybuka updated
https://github.com/llvm/llvm-project/pull/90935
>From 8468a10bf34e4c432b181d40c370043ad21b5801 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH] Revert "Revert "[OpenMP][TR12] change property of map-type
modifier
vitalybuka wrote:
> 7c28408
good point, maybe not, I scheduled it as with, without rebase.
Let's try again.
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
jyu2-git wrote:
> > Looks broken
> > https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
>
> This is special build from this PR see `git status` here
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
Hi @vitalybuka, thanks for looking it up.
vitalybuka wrote:
> Looks broken
> https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
This is special build from this PR see `git status` here
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/6/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
https://github.com/vitalybuka requested changes to this pull request.
Looks broken
https://lab.llvm.org/buildbot/#/builders/5/builds/43104/steps/9/logs/stdio
https://github.com/llvm/llvm-project/pull/90935
___
cfe-commits mailing list
cfe-commits@list
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (jyu2-git)
Changes
Reland llvm/llvm-project#90499
---
Patch is 28.99 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/90935.diff
4 Files Affected:
- (modified) clang/include/clang/Basic/D
https://github.com/jyu2-git created
https://github.com/llvm/llvm-project/pull/90935
Reland llvm/llvm-project#90499
>From 7c28408e39f83dd44a59caf7b8539e7920504277 Mon Sep 17 00:00:00 2001
From: jyu2-git
Date: Thu, 2 May 2024 20:55:18 -0700
Subject: [PATCH] Revert "Revert "[OpenMP][TR12] change
21 matches
Mail list logo
