aganea wrote:
I managed to repro. It is actually this, still open, issue:
https://github.com/microsoft/STL/issues/1066
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zmodem wrote:
I believe we're on the 10.0.19041.0 (2020-04) SDK and VS 16.6.1, running on
Windows 10. The rpmalloc version is bc1923f which is probably old by now.
I'll try with the latest rpmalloc version, and will also see if I can dig into
the stl headers a bit, but I won't be able to get
aganea wrote:
@zmodem I haven’t been able to repro with the recipe posted on
https://crbug.com/1487548. I am using latest rpmalloc (main branch), latest VS
2022, latest WinSDK. I am running on Win11, on a AMD Ryzen9 CPU. Are you
running on WinServer2022? Are able to give more precision on the
petrhosek wrote:
We have seen occasional segfaults when using rpmalloc in other tools such as GN
and Ninja which we haven't been able to get to the bottom of so we eventually
switched to another allocator. It's possible that it's the same issue here, in
which case perhaps we should reconsider
zmodem wrote:
Just tried it, but I didn't hit any asserts.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aganea wrote:
@zmodem Can you add `ENABLE_ASSERTS` on [this
line](https://github.com/llvm/llvm-project/blob/720e3bacbd9fdba05645a4d621d43ad712c44df3/llvm/lib/Support/CMakeLists.txt#L107)
and run the test again, see if that gives something interesting?
zmodem wrote:
We're seeing unit test crashes on Windows when building with rpmalloc (via
`LLVM_INTEGRATED_CRT_ALLOC`). It's crashing here:
https://github.com/google/googletest/blob/v1.14.0/googletest/include/gtest/internal/gtest-port.h#L2092
+ @aganea have you also hit this?
(Our bug:
bjope wrote:
> > Ok, seems like the only problem is the MemProf unit test
> > compiler-rt/lib/memprof/tests/
> > So if I manually disable that I don't see any other failures with this
> > patch.
>
> I think any components that uses freshly built clang (stage1) could
> potentially run into
zeroomega wrote:
> Ok, seems like the only problem is the MemProf unit test
> compiler-rt/lib/memprof/tests/
>
> So if I manually disable that I don't see any other failures with this patch.
I think any components that uses freshly built clang (stage1) could potentially
run into this problem
mikaelholmen wrote:
Ok, seems like the only problem is the MemProf unit test
compiler-rt/lib/memprof/tests/
So if I manually disable that I don't see any other failures with this patch.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits
mikaelholmen wrote:
I see compilation problems with this patch.
By mistake I originally posted about the problems in
https://github.com/llvm/llvm-project/issues/66268#issuecomment-1718791073
So the problem: On a RHEL7 server we see stuff like:
`
In file included from
zeroomega wrote:
Relanded as a866ce789eb99da4d7a486eeb60a53be6c75f4fd. I will monitor the bots
and manually trigger clean build if linker error appears again.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
zeroomega wrote:
I look through all the bot failures from my mail box and I think so far there
are two issues:
* `error: unused function 'operator<<'` issue, this is caused by a type
matching bug I introduced in the roll and it will be addressed by:
zeroomega wrote:
I looked into the "unused functions" issue shown up in bots like:
https://lab.llvm.org/buildbot/#/builders/57/builds/29853 .
The root cause is that GoogleTest changed the way it converts an arbitrary
object into string. In the past, any object that cannot be printed to the
zeroomega wrote:
> I'm seeing some unused functions in files that haven't been changed in years,
> which I'm guessing come from this update - did the new googletest change how
> custom output works?
>
> ```
> llvm/unittests/Support/JSONTest.cpp:490:27: error: unused function
> 'operator<<'
bogner wrote:
I'm seeing some unused functions in files that haven't been changed in years,
which I'm guessing come from this update - did the new googletest change how
custom output works?
```
llvm/unittests/Support/JSONTest.cpp:490:27: error: unused function 'operator<<'
zeroomega wrote:
First bot failure: https://lab.llvm.org/buildbot/#/builders/127/builds/55068
```
[18/126] Generating SANITIZER_TEST_OBJECTS.sanitizer_lzw_test.cpp.x86_64.o
FAILED:
projects/compiler-rt/lib/sanitizer_common/tests/SANITIZER_TEST_OBJECTS.sanitizer_lzw_test.cpp.x86_64.o
https://github.com/zeroomega closed
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
I'm happy with this, the bots will catch any environmental issues that you
haven't found yet. LGTM.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
zeroomega wrote:
I have locally tested this PR using gcc 12.2.0 on Linux x64 and MSVC from
VS2019, both passed without issues. @pogo59 Do you have any concerns or
suggestions before we merge this?
https://github.com/llvm/llvm-project/pull/65823
___
https://github.com/petrhosek approved this pull request.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
zeroomega wrote:
I have addressed all review comments in the the latest amend commits. Please
take a look.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
https://github.com/zeroomega resolved
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
zeroomega wrote:
My checkout just stales. Thanks for pointing it out.
https://github.com/llvm/llvm-project/pull/65823
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
PRIVATE googletest googlemock
)
add_subdirectory(UnitTestMain)
if (LLVM_INSTALL_GTEST)
install(TARGETS llvm_gtest
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
https://github.com/pogo59 commented:
Nice to see the LLVM intrusion into googletest proper is very minimized!
IME, testing on Linux with both gcc and clang as build compilers is very
helpful. With Windows/MSVC that covers the three main cases.
https://github.com/llvm/llvm-project/pull/65823
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -10,14 +10,10 @@ Cleaned up as follows:
# Remove all the unnecessary files and directories
$ rm -f CMakeLists.txt configure* Makefile* CHANGES CONTRIBUTORS README
README.md .gitignore
$ rm -rf build-aux make msvc scripts test docs
-$ rm -f `find . -name \*\.pump`
$ rm -f
@@ -1,22 +1,21 @@
LLVM notes
--
-This directory contains Google Test 1.10.0, with all elements removed except
for
-the actual source code, to minimize the addition to the LLVM distribution.
+This directory contains Google Test 1.14.0,
+revision
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
PRIVATE googletest googlemock
)
add_subdirectory(UnitTestMain)
if (LLVM_INSTALL_GTEST)
install(TARGETS llvm_gtest
@@ -77,18 +77,18 @@ endif ()
target_include_directories(llvm_gtest
PUBLIC $
$
- $
- $
+ $
+ $
petrhosek wrote:
This is undoing a change made recently in
https://github.com/joker-eph approved this pull request.
Agree with @MaskRay for the style: we should minimize the diff with upstream as
much as possible!
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
Thank you for the change! `ninja check-llvm check-clang check-clang-tools
check-flang check-mlir check-lld check-polly` parses.
> The GoogleTest code also uses a different code style (Google C++ style
> instead of LLVM style). Shall I reformat the entire GoogleTest code base?
https://github.com/github-actions[bot] labeled
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zeroomega review_requested
https://github.com/llvm/llvm-project/pull/65823
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
47 matches
Mail list logo
