Author: Hsiangkai Wang Date: 2022-08-25T23:28:28Z New Revision: a8690143057b3e11c5aea5a45fcbabe3fd23b70b
URL: https://github.com/llvm/llvm-project/commit/a8690143057b3e11c5aea5a45fcbabe3fd23b70b DIFF: https://github.com/llvm/llvm-project/commit/a8690143057b3e11c5aea5a45fcbabe3fd23b70b.diff LOG: [AArch64] Filter out invalid code model in frontend. AArch64 only supports tiny, small, and large code model. Show error messages when users specify other code model. Fix https://github.com/llvm/llvm-project/issues/53402 Differential Revision: https://reviews.llvm.org/D132538 Added: Modified: clang/lib/Driver/ToolChains/Clang.cpp clang/test/Driver/mcmodel.c Removed: ################################################################################ diff --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp index 34bf7a797e7e8..eaf9a1f23fd50 100644 --- a/clang/lib/Driver/ToolChains/Clang.cpp +++ b/clang/lib/Driver/ToolChains/Clang.cpp @@ -5421,6 +5421,9 @@ void Clang::ConstructJob(Compilation &C, const JobAction &JA, CM == "tiny") { if (Triple.isOSAIX() && CM == "medium") CmdArgs.push_back("-mcmodel=large"); + else if (Triple.isAArch64() && (CM == "kernel" || CM == "medium")) + D.Diag(diag::err_drv_invalid_argument_to_option) + << CM << A->getOption().getName(); else A->render(Args, CmdArgs); } else { diff --git a/clang/test/Driver/mcmodel.c b/clang/test/Driver/mcmodel.c index 2c74c966744af..f8fb573f6f421 100644 --- a/clang/test/Driver/mcmodel.c +++ b/clang/test/Driver/mcmodel.c @@ -6,6 +6,8 @@ // RUN: %clang -target powerpc-unknown-aix -### -S -mcmodel=medium %s 2> %t.log // RUN: FileCheck --check-prefix=AIX-MCMEDIUM-OVERRIDE %s < %t.log // RUN: not %clang -c -mcmodel=lager %s 2>&1 | FileCheck --check-prefix=INVALID %s +// RUN: not %clang -c -target aarch64 -mcmodel=medium %s 2>&1 | FileCheck --check-prefix=AARCH64-MEDIUM %s +// RUN: not %clang -c -target aarch64 -mcmodel=kernel %s 2>&1 | FileCheck --check-prefix=AARCH64-KERNEL %s // TINY: "-mcmodel=tiny" // SMALL: "-mcmodel=small" @@ -15,3 +17,6 @@ // AIX-MCMEDIUM-OVERRIDE: "-mcmodel=large" // INVALID: error: invalid argument 'lager' to -mcmodel= + +// AARCH64-MEDIUM: error: invalid argument 'medium' to -mcmodel= +// AARCH64-KERNEL: error: invalid argument 'kernel' to -mcmodel= _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits